Skip to content

Verifier V1 [NUF-176]#302

Merged
Fly-Style merged 65 commits into
Nuffle-Labs:mainfrom
Fly-Style:feat/nuf-176
Oct 28, 2024
Merged

Verifier V1 [NUF-176]#302
Fly-Style merged 65 commits into
Nuffle-Labs:mainfrom
Fly-Style:feat/nuf-176

Conversation

@Fly-Style

@Fly-Style Fly-Style commented Oct 24, 2024 •
edited by carrion256
Loading

Copy link
Copy Markdown
Contributor

This patch adds Verifier V1 component as a part of DVN. In case, if received Packet was not verified, Verifier executes V1 verification algorithm:

  • fetches state root from aggregator;
  • fetches block state root by chain RPC API;
  • compares them and says is message is gud.

As a part of this change:

  • Compilation error fixed in indexer tests (f61cb8b)

This change is Reviewable

palozano and others added 30 commits October 22, 2024 11:31
@palozano
feat: reusable offchain workers
1e933b9
@palozano
chore: add receive lib abi
9fc8be8
@palozano
chore: fix overall flow
9d720c5
@palozano
chore: preparing for deployment, lacking correct header
9e1c1ee
@palozano
chore: ordering
1b02a1e
@palozano
refactor: more modular for later executor
d4b3c53
@palozano
chore: clean up
a9508f8
@palozano
refactor: dotenv -> dotenvy
af548f8
@palozano
chore: remove Cargo.lock
f825036
@palozano
refactor: move config to config-rs crate
131c351
@palozano
refactor: move to manual decoding
4a5cc5c
@palozano
chore: modularize
4894f4a
@palozano
chore: address pr comments on the worker
290bb85
@palozano
chore: move some files to lib imports
263cb0e
@palozano
chore: remove unused tests for now
b9b81fb
@palozano
chore: reorder imports
62994a8
@serrrfirat @palozano
wip: fix dockerfile so it doesn't break current indexer
5da950a
@serrrfirat @palozano
wip: fix docker compose for setups
58d2454
@serrrfirat @palozano
wip: big cargo clean up
c5359dc
@palozano
chore: remove unused
f1624fd
@palozano
chore: add tests to manual decoding
5bf79ef
@palozano
chore: use const instead of magic number
90c0e70
@palozano
chore: comments
1433aac
@palozano
chore: address pr comments
9293854
@palozano
chore: address pr comments
ce2d6e6
@palozano @carrion256
Update indexer/Dockerfile
2d9d590 
Co-authored-by: Don <37594653+dndll@users.noreply.github.com>
@palozano
chore: fix after refactor
ed43e71
@palozano
chore: bls bn254 signature takes two uint256
0ed696f
@palozano
chore: remove v1 contract, leaving only v2 (without version suffix)
ec06783
@palozano
chore: address comments
20a711c
coderabbitai[bot]

This comment was marked as outdated.

Sign in to view

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

@Nuffle-Labs Nuffle-Labs deleted a comment from coderabbitai Bot Oct 25, 2024
coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

serrrfirat
serrrfirat requested changes Oct 28, 2024
View reviewed changes
Comment thread aggregator/aggregator.go Outdated
Comment thread aggregator/rest_server/server.go Outdated
Comment thread aggregator/rest_server/server.go Outdated
Comment thread aggregator/aggregator.go Outdated
Comment thread workers/src/bin/dvn.rs
Comment thread workers/src/verifier.rs Outdated
Comment thread workers/src/verifier.rs
Comment thread workers/src/verifier.rs Outdated
Comment thread workers/src/verifier.rs Outdated
Comment thread workers/src/verifier.rs
serrrfirat
serrrfirat requested changes Oct 28, 2024
View reviewed changes

@serrrfirat serrrfirat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments - lets clarify some design decisions and small nitpicks and we can merge.

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

serrrfirat
serrrfirat reviewed Oct 28, 2024
View reviewed changes
Comment thread workers/src/verifier.rs Outdated
serrrfirat
serrrfirat previously approved these changes Oct 28, 2024
View reviewed changes

@serrrfirat serrrfirat left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small comment about function name. Otherwise lgtm

coderabbitai[bot]

This comment was marked as resolved.

Sign in to view

@Nuffle-Labs Nuffle-Labs deleted a comment from coderabbitai Bot Oct 28, 2024
@Fly-Style Fly-Style requested a review from serrrfirat October 28, 2024 12:14
palozano
palozano approved these changes Oct 28, 2024
View reviewed changes

@palozano palozano left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Looks good overall

Comment thread workers/src/verifier.rs
Comment thread workers/src/verifier.rs
@Fly-Style Fly-Style merged commit 2c9fc41 into Nuffle-Labs:main Oct 28, 2024
@Fly-Style Fly-Style deleted the feat/nuf-176 branch October 28, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@serrrfirat serrrfirat serrrfirat approved these changes

@carrion256 carrion256 Awaiting requested review from carrion256

+1 more reviewer

@palozano palozano palozano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Fly-Style Fly-Style

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fly-Style @serrrfirat @palozano