Test out: https://github.com/emberjs/ember.js/pull/21520 - #2212
Open
NullVoxPopuli wants to merge 9 commits into
Open
Test out: https://github.com/emberjs/ember.js/pull/21520#2212NullVoxPopuli wants to merge 9 commits into
NullVoxPopuli wants to merge 9 commits into
Conversation
|
|
The previous tarball (+5916d3e8) broke the build and lints: - @ember/runloop stopped exporting _backburner, which ember-qunit and @ember/test-helpers import, so the repl app's bundle failed to resolve and the ssg prerender crashed on the missing dist. - The Deferred interface that replaced RSVP's in @ember/application used property-syntax resolve/reject (strictly contravariant), making App.create() unassignable to setApplication() in the tutorial app's type check. The new tarball restores the _backburner stub (wired to real pending-render state so settled() still waits), drains scheduled destroys synchronously on instance destroy (the ssg worker wipes the document right after destroy() returns), and resolves renderSettled() via a scheduler flush like classic did. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Collaborator
|
Fixed — the failures were all in the experimental ember build, now repaired on the
All of limber's builds, lints, and chrome/node/firefox tests pass locally against the regenerated tarball ( I can't push to this branch (it lives on the main repo). Two options:
|
This was referenced Aug 9, 2026
Merged
…rner The tarball moves to all-optimizations+60f0fc94, which drops the _backburner compat stub entirely: backburner is gone from the framework, not impersonated. The consumers that imported it are patched via pnpm patchedDependencies: - @ember/test-helpers: getSettledState reads the new isRenderPending() from @ember/renderer (the synchronous probe its TODO always asked for, covering pending flushes and pending destroy drains); the backburner timer/instance/debug-info reads collapse to their truthful constants. - ember-qunit: drops the _backburner.DEBUG toggle from setupTestIsolationValidation (there is no backburner debug info). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e/all-optimizations Update ember-source tarball to all-optimizations+60f0fc94 + pnpm-patch _backburner consumers
Contributor
Footnotes
|
The @ember/test-helpers patch restructures settled(): the render condition is event-driven (await renderSettled(), which resolves at the end of a scheduler flush that left every renderer valid) and only the poll-only conditions (test waiters, pending requests, transitions) re-check in a loop. Quiet is confirmed from a macrotask before resolving: already-queued task sources (worker messages, zero-delay timers) may re-register waiters or dirty state, and a microtask-context observation wins the race against them and settles early -- observed as a real 1-in-4 flake in ember-repl's Compiled() tests until the setTimeout confirm was added. waitUntil imposed the same boundary implicitly by scheduling every check via setTimeout. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The tarball moves to all-optimizations+c09efdc8, which replaces the isRenderPending() probe with edge reporting: the renderer notifies when work becomes outstanding and when it completes. The @ember/test-helpers patch turns those edges into an @ember/test-waiters waiter, so rendering settles through the same protocol as every other async source -- isSettled() needs no render clause (its old one is hardwired false to avoid double-counting), and a stuck render is named in test-waiter debug output. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Reworks the settledness patches per review on emberjs/ember-test-helpers#1574: @ember/test-waiters creates a promise per operation in beginAsync, endAsync resolves it and drops it from the pending map, and waitersSettled() composes the promises of whatever is still in flight. @ember/test-helpers' settled() awaits that alongside renderSettled(). The fallback tick stays for waiters that cannot announce completion (pull-only Waiter implementations -- waitersSettled returns a never-resolving promise while one is pending -- plus legacy waiters and request counters). It is 50ms rather than 10 so it loses the race to a frame-paced render tick; at 10ms it decided 30 of 117 iterations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review follow-ups from emberjs/ember-test-waiters#525: each pending operation's promise carries its own resolver, so the map holds nothing but promises and settled() passes them straight to Promise.all -- no array splat, no wrapper objects, no pointless .then. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…e/all-optimizations settled() awaits renderSettled() instead of polling the render half
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing out
Built from branch
all-optimizationsvia the test-ember-source workflow.