Skip to content

fix empty component template error - #825

Merged
NullVoxPopuli merged 2 commits into
NullVoxPopuli:mainfrom
amiarSlimane:fix-empty-component-error
Apr 4, 2023
Merged

fix empty component template error#825
NullVoxPopuli merged 2 commits into
NullVoxPopuli:mainfrom
amiarSlimane:fix-empty-component-error

Conversation

@amiarSlimane

Copy link
Copy Markdown

when we have an empty template the compiler is throwing an error, this error is caused by calling override function of magic-string with wrong arguments, i believe that checking that start is always below end will prevent the error from happening

An example of an empty template: <template></template>

@changeset-bot

changeset-bot Bot commented Apr 4, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 08c8ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@NullVoxPopuli

Copy link
Copy Markdown
Owner

Thank you!!!

@NullVoxPopuli

Copy link
Copy Markdown
Owner

I've ported this fix over to ember-template-imports as well: ember-cli/ember-template-imports#146

@NullVoxPopuli
NullVoxPopuli merged commit 85c4c4a into NullVoxPopuli:main Apr 4, 2023
@amiarSlimane

Copy link
Copy Markdown
Author

you are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants