Skip to content

[19.0][MIG] event_*: analysis annotations for simple submodules#5636

Open
dnplkndll wants to merge 1 commit into
OCA:19.0from
ledoent:19.0-mig-event-family-trivial
Open

[19.0][MIG] event_*: analysis annotations for simple submodules#5636
dnplkndll wants to merge 1 commit into
OCA:19.0from
ledoent:19.0-mig-event-family-trivial

Conversation

@dnplkndll
Copy link
Copy Markdown

@dnplkndll dnplkndll commented May 15, 2026

Annotation-only coverage for 6 event_* submodules.

In scope: event_booth, event_booth_sale, event_crm, event_product, event_sale, event_sms (sibling added).

noupdate decisions:

  • event_productproduct_category_events parent_id (eval ref with raise_if_not_found=False) left active: default-hierarchy alignment on a shipped base category, safe on user databases.
  • event_sms (sibling added) — two sms.template.lang clearing records commented out: preserves operator-set translation language.

The complex event module (slots + question m2m promotion) is deferred to #5637 for focused review.

@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:19.0 labels May 15, 2026
@dnplkndll dnplkndll force-pushed the 19.0-mig-event-family-trivial branch from 5dfe0b9 to 0c85be5 Compare May 19, 2026 01:16
@dnplkndll dnplkndll marked this pull request as ready for review May 19, 2026 01:16
@dnplkndll dnplkndll force-pushed the 19.0-mig-event-family-trivial branch from 0c85be5 to a0e0969 Compare May 19, 2026 13:52
NEW ir.ui.view: event_product.event_registration_view_graph
NEW ir.ui.view: event_product.view_event_registration_ticket_tree

# NOTHING TO DO
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to analyze if pertinent (otherwise you should comment out lines that you do not want to udapte in the following file) and load https://github.com/OCA/OpenUpgrade/blob/19.0/openupgrade_scripts/scripts/event_product/19.0.1.0/noupdate_changes.xml

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — added a ---noupdate_changes.xml--- block to the work doc explaining the decision. The single record (product_category_events parent_id → product.product_category_services with raise_if_not_found=False) is left active: it's a default-hierarchy alignment on a base shipped category, and the fallback flag makes it safe on databases where the parent category was renamed or removed.
Users who reparented the Events category under a custom tree would be silently rewritten — happy to flip to commented-out if you'd prefer the strictly conservative path.

But then the default would not get the update.

Comment thread docsource/modules180-190.rst Outdated
| event_sale | | |
| event_sale |Nothing | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| event_sms | |No DB layout changes. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to be exhaustive, on this one also there is a change in noupdate XML :
https://github.com/OCA/OpenUpgrade/blob/19.0/openupgrade_scripts/scripts/event_sms/19.0.1.0/noupdate_changes.xml

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — added event_sms to the PR. The two sms.template records clearing lang are commented out: clearing the language on event_registration / event_reminder templates would silently drop any
operator-set translation language. The new event_sms/19.0.1.0/upgrade_analysis_work.txt records the decision.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added event_sms to the PR. The two sms.template records clearing lang are commented out — clearing would drop operator-set translation language. See event_sms/19.0.1.0/upgrade_analysis_work.txt for the rationale. Docsource row updated to Done | Nothing to do.

Comment thread docsource/modules180-190.rst Outdated
| event | | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| event_booth | | |
| event_booth |Nothing | |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| event_booth |Nothing | |
| event_booth |Done |Nothing to do |

Same for following ones

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied to all 5 event_* rows + the new event_sms row in 326ebc9 — col 2 = Done, col 3 = Nothing to do

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied to all 6 rows in abece79.

@dnplkndll dnplkndll force-pushed the 19.0-mig-event-family-trivial branch 2 times, most recently from 326ebc9 to abece79 Compare May 20, 2026 17:30
@dnplkndll dnplkndll changed the title [19.0][MIG] event_*: analysis annotations for 5 simple submodules [19.0][MIG] event_*: analysis annotations for simple submodules May 20, 2026
@dnplkndll
Copy link
Copy Markdown
Author

@remi-filament — addressed all three threads in abece79:

  1. event_product/noupdate_changes.xml — work doc now has a ---noupdate_changes.xml--- block; record left active (default-hierarchy alignment, raise_if_not_found=False is defensive). Open to flipping if you'd prefer strictly conservative.
  2. event_sms added to PR scope. Its two sms.template records clearing lang are commented out to preserve operator translations. New event_sms/19.0.1.0/upgrade_analysis_work.txt records the decision.
  3. docsource — all six event_* rows now Done | Nothing to do.

Fork CI green on both seeds. Ready for re-review.

@dnplkndll dnplkndll force-pushed the 19.0-mig-event-family-trivial branch from abece79 to 76b7a6c Compare May 20, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:openupgrade_scripts Module openupgrade_scripts series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants