[19.0][MIG] event_*: analysis annotations for simple submodules#5636
[19.0][MIG] event_*: analysis annotations for simple submodules#5636dnplkndll wants to merge 1 commit into
Conversation
5dfe0b9 to
0c85be5
Compare
0c85be5 to
a0e0969
Compare
| NEW ir.ui.view: event_product.event_registration_view_graph | ||
| NEW ir.ui.view: event_product.view_event_registration_ticket_tree | ||
|
|
||
| # NOTHING TO DO |
There was a problem hiding this comment.
You need to analyze if pertinent (otherwise you should comment out lines that you do not want to udapte in the following file) and load https://github.com/OCA/OpenUpgrade/blob/19.0/openupgrade_scripts/scripts/event_product/19.0.1.0/noupdate_changes.xml
There was a problem hiding this comment.
Thanks — added a ---noupdate_changes.xml--- block to the work doc explaining the decision. The single record (product_category_events parent_id → product.product_category_services with raise_if_not_found=False) is left active: it's a default-hierarchy alignment on a base shipped category, and the fallback flag makes it safe on databases where the parent category was renamed or removed.
Users who reparented the Events category under a custom tree would be silently rewritten — happy to flip to commented-out if you'd prefer the strictly conservative path.
But then the default would not get the update.
| | event_sale | | | | ||
| | event_sale |Nothing | | | ||
| +---------------------------------------------------+----------------------+-------------------------------------------------+ | ||
| | event_sms | |No DB layout changes. | |
There was a problem hiding this comment.
If you want to be exhaustive, on this one also there is a change in noupdate XML :
https://github.com/OCA/OpenUpgrade/blob/19.0/openupgrade_scripts/scripts/event_sms/19.0.1.0/noupdate_changes.xml
There was a problem hiding this comment.
Good catch — added event_sms to the PR. The two sms.template records clearing lang are commented out: clearing the language on event_registration / event_reminder templates would silently drop any
operator-set translation language. The new event_sms/19.0.1.0/upgrade_analysis_work.txt records the decision.
There was a problem hiding this comment.
Added event_sms to the PR. The two sms.template records clearing lang are commented out — clearing would drop operator-set translation language. See event_sms/19.0.1.0/upgrade_analysis_work.txt for the rationale. Docsource row updated to Done | Nothing to do.
| | event | | | | ||
| +---------------------------------------------------+----------------------+-------------------------------------------------+ | ||
| | event_booth | | | | ||
| | event_booth |Nothing | | |
There was a problem hiding this comment.
| | event_booth |Nothing | | | |
| | event_booth |Done |Nothing to do | |
Same for following ones
There was a problem hiding this comment.
Applied to all 5 event_* rows + the new event_sms row in 326ebc9 — col 2 = Done, col 3 = Nothing to do
326ebc9 to
abece79
Compare
|
@remi-filament — addressed all three threads in abece79:
Fork CI green on both seeds. Ready for re-review. |
abece79 to
76b7a6c
Compare
Annotation-only coverage for 6
event_*submodules.In scope:
event_booth,event_booth_sale,event_crm,event_product,event_sale,event_sms(sibling added).noupdate decisions:
event_product—product_category_eventsparent_id (eval ref withraise_if_not_found=False) left active: default-hierarchy alignment on a shipped base category, safe on user databases.event_sms(sibling added) — twosms.template.langclearing records commented out: preserves operator-set translation language.The complex
eventmodule (slots + question m2m promotion) is deferred to #5637 for focused review.