[19.0][MIG] im_livechat#5642
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
dnplkndll
force-pushed
the
19.0-mig-im-livechat-chatbot-condition
branch
from
080fc41 to
cf341e0
Compare
dnplkndll
force-pushed
the
19.0-mig-im-livechat-chatbot-condition
branch
from
cf341e0 to
dd451c3
Compare
dnplkndll
changed the title
| im_livechat / res.users / livechat_channel_ids (many2many): NEW relation: im_livechat.channel | ||
| im_livechat / res.users.settings / livechat_expertise_ids (many2many): NEW relation: im_livechat.expertise | ||
|
|
||
| # DONE: chatbot_only_if_no_operator (boolean) -> chatbot_enabled_condition (selection) handled by pre-migration rename_columns (preserve legacy) + post-migration UPDATE mapping TRUE->'only_if_no_operator'. |
There was a problem hiding this comment.
You need to put DONE comments only next to fields which require a migration script.
Also here you do not need to copy the column, since it will not be deleted by OpenUpgrade so you can reuse directly without legacy name.
The other ones need to be marked NOTHING TO DO
There was a problem hiding this comment.
Addressed in bde040f — pre-migration now does only the noupdate ir.rule deletion (no column copy, since the old column is preserved automatically by OpenUpgrade when new field name differs). Post-migration reuses chatbot_only_if_no_operator directly. Work-doc markers per-group, # NOTHING TO DO next to additive lines and # DONE only next to the chatbot pair.
| DEL ir.rule: im_livechat.ir_rule_discuss_channel_group_im_livechat_group_manager (noupdate) | ||
| DEL ir.rule: im_livechat.ir_rule_discuss_channel_member_group_im_livechat_group_manager (noupdate) |
There was a problem hiding this comment.
You need to manually delete these noupdate rules
There was a problem hiding this comment.
Done in bde040f — pre-migration deletes both noupdate ir.rule records via direct SQL.
dnplkndll
changed the title
dnplkndll
force-pushed
the
19.0-mig-im-livechat-chatbot-condition
branch
from
dd451c3 to
bde040f
Compare
|
@remi-filament — addressed both threads in bde040f:
Fork CI green on both seeds. Title + body refreshed to match v2 shape. Ready for re-review. |
dnplkndll
changed the title
3 participants
19.0 replaces the boolean
im_livechat.channel.rule.chatbot_only_if_no_operatorwith a selection fieldchatbot_enabled_condition(always/only_if_no_operator/only_if_operator). Because the new field has a different name, OpenUpgrade preserves the old column automatically — no pre-migration rename needed.(noupdate)ir.rule records removed in 19.0 (ir_rule_discuss_channel_group_im_livechat_group_manager,ir_rule_discuss_channel_member_group_im_livechat_group_manager). Standard module update doesn't sweep noupdate records.UPDATE ... SET chatbot_enabled_condition = 'only_if_no_operator' WHERE chatbot_only_if_no_operator = TRUE. Direct read of the preserved column (noget_legacy_nameneeded). FALSE rows keep ORM-set default ofalways.Test: asserts at least one rule has the new selection set post-migration.