[19.0][MIG] resource_booking: Migration to 19.0#187
Open
tishmen wants to merge 6 commits into
Open
Conversation
…ctly When using a booking type with a resource calendar that has a different time zone than the resource itself, the slots are returned with mixed time zones. This commit normalizes the behavior and ensures that slots are always returned in the time zone of the booking type. Steps to reproduce: Create a resource with the time zone America/Guayaquil, and a calendar that starts from 06:00 to 15:00. Create a resource booking type with a new calendar that starts from 09:00 to 16:00, and set the time zone to Europe/Madrid. Before this commit, the slot displayed in the portal was 06:00, but it should have been 12:00. After this commit, the slot is displayed in the correct time zone (Madrid) at 12:00. Note: The 06:00 in America/Guayaquil corresponds to 12:00 in Madrid standard time, not during daylight saving time. The tests use a freeze date in February.
Author
|
Supersedes #182 to preserve history per OCA 19.0 migration process. |
…_slot_duration
Author
|
Added temporary dependency in test-requirements.txt to OCA/web#3306 (web_calendar_slot_duration) per OCA guidelines. Will drop once 19.0 wheel is available. |
Member
|
/ocabot migration resource_booking |
Author
|
Update: temporary dependency now references OCA/web#3335 (v2 PR) instead of #3306. Will remove once 19.0 wheel is published. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
Member
|
Please, cherry-pick #210 to commit history before migration commit. |
github-actions
Bot
removed
the
stale
Contributor
|
@tishmen looks like the deps are merged. code looks good. |
dnplkndll
added a commit
to ledoent/calendar
that referenced
this pull request
May 16, 2026
Forward-port of resource_booking from 18.0 to the 19.0 series. Includes the following 18.0 fixes already merged upstream: - [FIX] access error on normal calendar - [FIX] display all slots in the same time zone correctly Supersedes OCA#187 (stale; 12 commits behind upstream/19.0 at the time of this squash; missing the post-merge updates and setup metapackage bits that have since landed in upstream/19.0). The substantive migration work in this commit is unchanged from Milan Topuzov's original PR; this commit re-bases it on current upstream/19.0 and drops the Weblate-owned i18n/*.po files and auto-generated requirements.txt that contributors should not include in a PR. Co-Authored-By: Víctor Martínez <victor.martinez@tecnativa.com> Co-Authored-By: Carlos Lopez <carlos.lopez@tecnativa.com> Co-Authored-By: Don Kendall <dkendall@ledoweb.com>
dnplkndll
added a commit
to ledoent/calendar
that referenced
this pull request
May 16, 2026
Forward-port of resource_booking from 18.0 to the 19.0 series. Includes the following 18.0 fixes already merged upstream: - [FIX] access error on normal calendar - [FIX] display all slots in the same time zone correctly Supersedes OCA#187 (stale; 12 commits behind upstream/19.0 at the time of this squash; missing the post-merge updates and setup metapackage bits that have since landed in upstream/19.0). The substantive migration work in this commit is unchanged from Milan Topuzov's original PR; this commit re-bases it on current upstream/19.0 and drops the Weblate-owned i18n/*.po files and auto-generated requirements.txt that contributors should not include in a PR. Co-Authored-By: Víctor Martínez <victor.martinez@tecnativa.com> Co-Authored-By: Carlos Lopez <carlos.lopez@tecnativa.com> Co-Authored-By: Don Kendall <dkendall@ledoweb.com>
dnplkndll
added a commit
to ledoent/calendar
that referenced
this pull request
May 16, 2026
Forward-port of resource_booking from 18.0 to the 19.0 series. Includes the following 18.0 fixes already merged upstream: - [FIX] access error on normal calendar - [FIX] display all slots in the same time zone correctly Supersedes OCA#187 (stale; 12 commits behind upstream/19.0 at the time of this squash; missing the post-merge updates and setup metapackage bits that have since landed in upstream/19.0). The substantive migration work in this commit is unchanged from Milan Topuzov's original PR; this commit re-bases it on current upstream/19.0 and drops the Weblate-owned i18n/*.po files and auto-generated requirements.txt that contributors should not include in a PR. Co-Authored-By: Víctor Martínez <victor.martinez@tecnativa.com> Co-Authored-By: Carlos Lopez <carlos.lopez@tecnativa.com> Co-Authored-By: Don Kendall <dkendall@ledoweb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Summary
Pre-commit
Temporary dependency
Added a temporary reference in
(root) to install from the PR ref, per OCA guidelines:
Tests
Command:
Result: 45 tests green locally.
Depends on: