[18.0][IMP] resource_booking: cap suggested slots with max_advance_booking_days#220
Open
dnplkndll wants to merge 1 commit into
Open
Conversation
…days Add an integer field max_advance_booking_days on resource.booking.type (SQL-constrained nonnegative, default 0) and gate _get_available_slots to skip starts beyond now + N days. Default 0 preserves the existing unbounded behavior. Useful when a booking type should not let requesters reserve weeks or months out (e.g. office desks released only one week ahead, sales call windows that should not commit to dates beyond a planning horizon). Co-Authored-By: Brenden Eshbach <brenden@techsystech.com>
Contributor
|
Hi @pedrobaeza, @ows-cloud, |
|
Thanks for your work on this @dnplkndll |
dnplkndll
force-pushed
the
18.0-imp-resource_booking-max_advance_booking_days
branch
from
29cef86 to
768dbea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an Integer field
max_advance_booking_daysonresource.booking.type(SQL-constrained nonnegative, default 0) and gate_get_available_slotsto skip starts beyondnow + N days. Default 0 preserves the existing unbounded behavior.Useful when a booking type should not let requesters reserve weeks or months out (office desks released only one week ahead, sales-call windows that should not commit dates beyond a planning horizon).
Adds 3 tests in
tests/test_backend.py:test_max_advance_booking_days_caps_slots,..._zero_keeps_full_range,..._constraint./ocabot merge minor