[18.0][ADD] resource_booking_google_meet: default bookings to Google Meet videocall#224
Open
dnplkndll wants to merge 2 commits into
Open
[18.0][ADD] resource_booking_google_meet: default bookings to Google Meet videocall#224dnplkndll wants to merge 2 commits into
dnplkndll wants to merge 2 commits into
Conversation
0b79020 to
f2f8d87
Compare
78841c6 to
0cf9cc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
resource_booking_google_meet— a small glue module that ensures thegoogle_calendarintegration auto-generates a unique Google Meet URL for eachresource.bookingconfirmation.Problem:
google_calendar._google_values()only addsconferenceData(whichtriggers Meet URL generation) when both
videocall_locationandlocationarefalsy on the event:
If the booking type has a physical address (
location), the condition fails even whenvideocall_locationis empty, so no Meet URL is ever generated.Fix: Override
_prepare_meeting_vals()to clearlocationfrom the meeting valswhen the booking type has no custom
videocall_location. This ensures thegoogle_calendarsync always requests conferencing for remote-only bookings.When the booking type does have a
videocall_location(e.g. a static Zoom personalroom), the module leaves everything unchanged.
Checklist
pyproject.toml,readme/, pre-commit clean)authorincludesOdoo Community Association (OCA)license: AGPL-3maintainers: ["dnplkndll"]google_calendarmock)