[19.0][MIG] hr_holidays_public: Migration to 19.0#239
Conversation
Add correct calculation of holidays in hr_public_holidays, instead of hr_holidays_compute_days. Remove dependancy of contracts. Add unlink at onchnage of public holiday lines. Update code. Fix flake. Update code, add calculation in hours, update views. Update flake. Update calendar creation with no attendances, otherwise default values were set. Remove config of show days/hours. Update flake. Update readme. Rename module. Updated holiday reports. Update klake and pylint. Update flaket. Update hr_holidays_views.xml Add readonly to show_full_days. Update code according with comments. Increase coverage. update flake8.
Hours part will be in module hr_holidays_hour.
Reduce to the minimum the footprint of this module, adding only public holidays as leaves in a transparent way by other modules.
|
Depends on: migration of calendar_public_holiday (#186) |
|
@namtnt Please use this to reference to the dependencies modules https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference(s)-to-another-pull-request(s) |
|
@namtnt and squash administrative commits. Check https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate for details. |
This has been totally reworked for decoupling parts, not depending now on hr_holidays_public, and making transparent its use for compatibility with other modules.
…idays are defined for each year
Since that PR, `_leave_intervals` is no longer called on days computations, so we intercept the batch method, but leaving the previous one for retro-compatibility.
…oliday in leave and hour start from resource calendar in 00:01
… has a public holiday TT56844
…lic holidays Example use case: - Define two dates as public holidays: 2025-12-30 + 2025-12-31 - Go to the Time off dashboard - Both dates (2025-12-30 + 2025-12-31) should be displayed as Public Holidays TT58183
cuongnmtm
force-pushed
the
19.0-mig-hr_holidays_public
branch
from
d3ca861 to
5f109ef
Compare
|
Hello, FYI I am taking over the migration of the dependent module |
|
Hello @cuongnmtm , @namtnt , I don't see the usual pre-commit fix before the migration was something missing or there was no change? |
@leemannd I believe there is no change from pre-commit; otherwise, they would be included in the MIG commit. |
|
Hello @cuongnmtm the module |
cuongnmtm
force-pushed
the
19.0-mig-hr_holidays_public
branch
from
5f109ef to
e4b48b6
Compare
Done. |
|
Hello @OCA/human-resources-maintainers , Do you have time to have a look at it and maybe merge it? |
|
This PR has the |
|
hi @pedrobaeza could you merge this pr please ? |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
/ocabot migration hr_holidays_public
/ocabot merge nobump
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 330d622. Thanks a lot for contributing to OCA. ❤️ |
20 participants
Depends on: