[19.0][MIG] mail_restrict_follower_selection: Migration to 19.0

[CRogos]

supersede: #150

• Fix pre-commit C8113: move mail_followers_edit.py from models/ to wizard/ directory
• Fix test failures round 1: replace env.ref() with set_param() in tests
• Fix safe_eval() API change: locals_dict= → positional context dict in Odoo 19.0

[MohamedOsman7]

LGTM

[MohamedOsman7]

@trisdoan can you please review this PR?

[MohamedOsman7]

@BhaveshHeliconia could you please make a review?

[BhaveshHeliconia]

What is the purpose of this?

[CRogos]

I had to ask the AI myself:

That lambda injects a ref() helper into safe_eval so domain expressions can resolve XML IDs safely at runtime.

In this code, safe_eval(str(domain), {"ref": lambda str_id: _id_get(self.env, str_id)}) means: when the evaluated domain contains something like ref("module.external_id"), call _id_get(self.env, str_id) and return the numeric database ID of that record. The helper itself is defined in utils.py and simply does env.ref(id_str).id, so it deliberately returns only the ID, not the recordset.

So I assume this enables you to use ref in the domain: e.g. [('industry_id','=',ref('base.res_partner_industry_A'))]

[BhaveshHeliconia]

I've verified on runboat and it gives some error. Could you please check on the runboat with this?

[CRogos]

I've fixed it and also improved the wizard domain filter.

[BhaveshHeliconia]

Is there any way to avoid overwriting onClickAddFollowers? If not, then please add a comment explaining why we need overwriting.

[CRogos]

You are totally right. How about this solution, by intercepting the doAction call? (I have to say that I am not an JS expert, but I like this solution from copilot)

[BhaveshHeliconia]

Suggested change

	<odoo>
	<odoo noupdate="1">

[BhaveshHeliconia]

This one is still pending.

[CRogos]

This is only demo data and not a real configuration. Not sure if we should flag this as noupdate.... OK I had a look into other demo data, you are right.

[BhaveshHeliconia]

• Can you replace setup() with following code snippet?

onClickAddFollowers() {
        const originalDoAction = this.action.doAction.bind(this.action);
        const saved = this.action;
        this.action = Object.assign(Object.create(this.action), {
            // The web client filters the loadViews context down to `lang` and
            // keys ending with `_view_ref`. We smuggle the followed record's
            // model through under a `_view_ref`-suffixed key so the wizard's
            // `get_view` can apply the per-model follower domain.
            doAction: (action, options) =>
                originalDoAction(
                    {
                        ...action,
                        context: {
                            ...action.context,
                            restrict_follower_res_model_view_ref:
                                this.props.thread.model,
                        },
                    },
                    options
                ),
        });
        try {
            return super.onClickAddFollowers();
        } finally {
            this.action = saved;
        }
    },

• By this, we can narrow scope from setup() to onClickAddFollowers() and also make use of arrow function.

[CRogos]

I've changed it even though I am not sure if this is a better solution. But maybe it is easier to understand because it is better linked to the reason of this change.

[BhaveshHeliconia]

Code and functional review LGTM!

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[CRogos]

@pedrobaeza could you merge?

[pedrobaeza]

/ocabot migration mail_restrict_follower_selection
/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 19.0-ocabot-merge-pr-183-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-183-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[OCA-git-bot]

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 19.0-ocabot-merge-pr-183-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.