[19.0][MIG] mail_activity_done: Migration to 19.0#198
Open
shamnaskoyani wants to merge 1 commit into
Open
Conversation
- Bump version to 19.0.1.0.0 - Remove legacy 18.0.1.0.0 migration directory (handled the 17.0 -> 18.0 archived/done column reshuffle and is no longer reachable from a 19.0 install) - Drop the corresponding obsolete test_migration test - Regenerate README.rst and static/description/index.html via pre-commit (oca-gen-addon-readme) - Add readme/CREDITS.md for the migration funding/contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migration of
mail_activity_donefrom 18.0 to 19.0.Changes:
19.0.1.0.0.migrations/18.0.1.0.0/directory. That script was specific to the 17.0 → 18.0 reshuffle (when the standalonedoneboolean column onmail.activitywas dropped in favour of usingactive+keep_doneon the activity type). It is unreachable from a 19.0 install and would never run again.test_migration, which exercised the now-removed script.README.rstandstatic/description/index.htmlviapre-commit(oca-gen-addon-readme).readme/CREDITS.mdand credit the migration contributor inreadme/CONTRIBUTORS.md.No model, view, controller, JS, or hook changes were required — the only Python code in the module is a single
keep_done = fields.Boolean(default=True)field onmail.activity.typeand apost_init_hookrunning a singleUPDATEstatement. None of the 19.0-breaking patterns (groups_id→group_ids,read_group→formatted_read_group,_()→self.env._(),self._context→self.env.context) are present.Test plan
mail_activity_doneon a fresh 19.0 database — confirmkeep_done = Trueis set on existingmail.activity.typerecords by the post-init hook.mail.activity.type— confirmkeep_donedefaults toTrue.pytest/odoo --test-tags mail_activity_done— confirmTestMailActivityDonepasses.Module maturity
Beta (matches the pre-19.0 maturity).
Closes the
mail_activity_doneentry on #85.