Skip to content

[IMP] pos_payment_description: simplify description computation #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
legalsylvain wants to merge 1 commit into
base: 16.0
Choose a base branch
from
+12 −19
Open

[IMP] pos_payment_description: simplify description computation #1541

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 12 additions & 19 deletions pos_payment_description/models/pos_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,28 +19,21 @@ class PosOrder(models.Model):
def _compute_payment_description(self):
for order in self:
details = []
for payment in order.payment_ids.filtered(
lambda x: x.payment_method_id.journal_id
):
details.append(
"%s: %s"
% (
payment.payment_method_id.journal_id.code,
formatLang(
self.env, payment.amount, currency_obj=payment.currency_id
),
)
)
for payment in order.payment_ids.filtered(
lambda x: not x.payment_method_id.journal_id
):
payment_dict = {}
for payment in order.payment_ids:
key = (payment.payment_method_id, payment.currency_id)
if key not in payment_dict:
payment_dict[key] = payment.amount
else:
payment_dict[key] += payment.amount

for (payment_method, currency), amount in payment_dict.items():
details.append(
"%s: %s"
% (
payment.payment_method_id.name,
formatLang(
self.env, payment.amount, currency_obj=payment.currency_id
),
payment_method.name,
formatLang(self.env, amount, currency_obj=currency),
)
)

order.payment_description = " - ".join(sorted(details))
Loading