[18.0][MIG] project_wbs: Migration to 18.0 by lbarry-apsl · Pull Request #1690 · OCA/project

lbarry-apsl · 2026-03-11T14:36:53Z

Module migrated to version 18.0

cc https://github.com/APSL
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko @peluko00 please review

the css was not migrated

enable opening the related view even when empty (needed for quick project creation)

[IMP]test_coverage

Currently translated at 1.8% (1 of 55 strings) Translation: project-12.0/project-12.0-project_wbs Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_wbs/de/

…ccount

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-12.0/project-12.0-project_wbs Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_wbs/

…nherit

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_wbs Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_wbs/

Currently translated at 100.0% (53 of 53 strings) Translation: project-15.0/project-15.0-project_wbs Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_wbs/it/

hbrunn

this needs much more work, amongst others compatibility with project_parent, lack of which is part of why tests fail left and right here

cubells

👍

LGTM

Code review and test

peluko00

LGTM!

mpascuall

LGTM!

AaronHForgeFlow

When I click on WBS list to see the children:

An I hit create then I expect to be able to be the name of the new project for quick creation, but it seems to be readonly, can you check?

I understand that make this a dependent of project_parent is the natural evolution of the module.

lbarry-apsl · 2026-05-12T13:03:46Z

Done @AaronHForgeFlow !

Agreed, that makes sense as the next step.
This PR is the 18.0 migration of project_wbs; the inline creation adjustment is part of that migration.
I suggest handling the project_parent dependency/refactor in a separate follow-up PR.

lbarry-apsl · 2026-05-19T06:31:10Z

Hi @hbrunn and @AaronHForgeFlow , can you review please?

AaronHForgeFlow

LGTM Functional.

Also I am no so sure we should make it depend on project_parent. This module relies on the analytic_account hierarchy not the project hierarchy. Moving all the features from the analytic account to the project is a dramatic change that affects all the features in the module and all the module that relies on this one, and requires complex migration scripts, for so little benefit.

hbrunn

Also I am no so sure we should make it depend on project_parent. This module relies on the analytic_account hierarchy not the project hierarchy. Moving all the features from the analytic account to the project is a dramatic change that affects all the features in the module and all the module that relies on this one, and requires complex migration scripts, for so little benefit.

nobody has asked for this. But not breaking it is mandatory.

Out of scope for the migration, but I'd like to see this module gate its functionality with a type field/feature flag on accounts and projects, so that you can have analytic accounts and projects that don't have anything to do with WBS

hbrunn · 2026-05-25T07:12:42Z

+    @api.model
+    def _default_parent(self):
+        return self.env.context.get("parent_id", None)
+
+    @api.model
+    def _default_partner(self):
+        return self.env.context.get("partner_id", None)


please remove those and change context keys to default_* where appropriate

hbrunn · 2026-05-25T07:21:20Z

+    _inherit = "account.analytic.account"
+    _order = "complete_wbs_code"
+
+    def get_child_accounts(self):


are you sure this is faster than a modern child_of search?

hbrunn · 2026-05-25T07:22:19Z

+                account._complete_wbs_code_calc()
+                account._complete_wbs_name_calc()
+        if "active" in vals:
+            for account in self:


Suggested change

for account in self:

for account in self.with_context(active_test=False):

otherwise you won't find nonactive projects

hbrunn · 2026-05-25T07:26:36Z

+    parent_id = fields.Many2one(
+        default=_default_parent, string="Parent Analytic Account"
+    )
+    partner_id = fields.Many2one(default=_default_partner)


remove as of above

hbrunn · 2026-05-25T07:28:39Z

+        default = {}
+        default["code"] = self.env["ir.sequence"].next_by_code(
+            "account.analytic.account.code"
+        )


why do we need this? the default should be provided by account_analytic_sequence already.

in any case, you overwrite existing defaults here which is a no-no

hbrunn · 2026-05-25T07:33:05Z

+        "within the project WBS hierarchy",
+        store=True,
+    )
+    code = fields.Char(copy=False)


remove, account_analytic_sequence already does this

hbrunn · 2026-05-25T07:34:12Z

+    def copy(self, default=None):
+        if self.mapped("project_ids"):
+            raise ValidationError(
+                _("Duplicate the project instead of the " "Analytic Account")


join the string. but I don't think I agree with making this a hard failure anyways

hbrunn · 2026-05-25T07:38:37Z

+        return res
+
+    @api.depends("name")
+    def name_get(self):


name_get isn't a thing any more, see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0

code_get should be integrated here as it's not used anywhere else

hbrunn · 2026-05-25T07:44:13Z

+            "UNIQUE (complete_wbs_code)",
+            "The full wbs code must be unique!",
+        ),
+    ]


I stopped reviewing here, before asking for another review I invite you to adhere to all migration notes for all versions mentioned in https://github.com/OCA/maintainer-tools/wiki#migration, including reordering fields and functions, assigning compute functions by name and not by reference, and having a critical look on all field definitions if you don't redefine things that are already done elsewhere

AaronHForgeFlow and others added 30 commits March 11, 2026 14:25

Project wbs

2113fd5

[MIG][10.0]project_wbs

7bee9a5

Comment out project stages since it's not pertinent in version 10

663709d

Move analytic account fields inside the notebook, since

324419d

the css was not migrated

Show wbs code since without it sorting doesn't work

c47ef70

Version 10 uses decorations instead of line colors

9833bcb

Sort the form and tree view to follow the v 10 user experience

c0ec086

Restore kanban and tree navigation, correction on python to

31a8de6

enable opening the related view even when empty (needed for quick project creation)

[FIX]view inheritability, default account_class in project

e329cb9

[IMP]test_coverage

[UPD] Update project_wbs.pot

b0179e1

[MIG]project_wbs: Migration to v11

5f1bf4c

[MIG] project_wbs: Migration to v12

b8bd078

[IMP] minor fixes

2734689

Increase test coverage

3959598

[IMP] minor fixes

1de276b

[ENH]breadcrump text when navigating wbs elements

5edd5ea

[FIX] Wrong pre_init_hook

f5f3f1d

[REF] Don't inherit project.project from account.analytic.account

fcadaac

[FIX] Minor fixes

78998bd

[UPD] Update project_wbs.pot

3b39d28

[UPD] README.rst

4505c0a

[FIX] init_hook: minor fix (assure codes are flushed to database)

a20afb3

project_wbs 12.0.1.0.1

ba040af

[ADD] Migration scripts to v12

f152dd8

Added translation using Weblate (German)

126d8ae

Translated using Weblate (German)

3cf3280

Currently translated at 1.8% (1 of 55 strings) Translation: project-12.0/project-12.0-project_wbs Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_wbs/de/

[FIX]project_wbs. parent analytic is computed based on its analytic a…

92ec37c

…ccount

[UPD] Update project_wbs.pot

83da7f1

project_wbs 12.0.1.1.0

d46d711

Update translation files

96bd3e8

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-12.0/project-12.0-project_wbs Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_wbs/

AaronHForgeFlow and others added 7 commits March 11, 2026 14:25

[IMP] project_wbs: cleaner view for child WBS element and easier to i…

c030e70

…nherit

[IMP] project_wbs: update maintainer, author & Copyright

1050f7f

[UPD] Update project_wbs.pot

ca293ed

[BOT] post-merge updates

f4fa193

Update translation files

3a049c0

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: project-15.0/project-15.0-project_wbs Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_wbs/

Translated using Weblate (Italian)

2f1131d

Currently translated at 100.0% (53 of 53 strings) Translation: project-15.0/project-15.0-project_wbs Translate-URL: https://translation.odoo-community.org/projects/project-15-0/project-15-0-project_wbs/it/

[IMP] project_wbs: pre-commit auto fixes

bba5708

hbrunn requested changes Mar 19, 2026

View reviewed changes

leemannd mentioned this pull request Apr 7, 2026

project_wbs is stuck at v15. Anyone working on upgrading to v18? #1567

Open

lbarry-apsl force-pushed the 18.0-mig-project_wbs branch from 5c7d053 to de7b1ab Compare May 7, 2026 10:47

OCA-git-bot added series:18.0 mod:project_wbs Module project_wbs labels May 7, 2026

lbarry-apsl force-pushed the 18.0-mig-project_wbs branch 4 times, most recently from 58fdc87 to e29d1be Compare May 7, 2026 14:38

cubells approved these changes May 8, 2026

View reviewed changes

lbarry-apsl requested a review from hbrunn May 8, 2026 07:24

AaronHForgeFlow self-requested a review May 8, 2026 09:13

peluko00 approved these changes May 8, 2026

View reviewed changes

mpascuall approved these changes May 8, 2026

View reviewed changes

AaronHForgeFlow reviewed May 9, 2026

View reviewed changes

lbarry-apsl force-pushed the 18.0-mig-project_wbs branch from e29d1be to 1f4b048 Compare May 12, 2026 11:41

[MIG] project_wbs: Migration to 18.0

1293d87

lbarry-apsl force-pushed the 18.0-mig-project_wbs branch from 1f4b048 to 1293d87 Compare May 12, 2026 11:46

lbarry-apsl requested a review from AaronHForgeFlow May 14, 2026 07:56

AaronHForgeFlow reviewed May 19, 2026

View reviewed changes

hbrunn requested changes May 25, 2026

View reviewed changes

	for account in self:
	for account in self.with_context(active_test=False):

Uh oh!

Conversation

lbarry-apsl commented Mar 11, 2026

Uh oh!

hbrunn left a comment

Choose a reason for hiding this comment

Uh oh!

cubells left a comment

Choose a reason for hiding this comment

Uh oh!

peluko00 left a comment

Choose a reason for hiding this comment

Uh oh!

mpascuall left a comment

Choose a reason for hiding this comment

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

lbarry-apsl commented May 12, 2026

Uh oh!

lbarry-apsl commented May 19, 2026

Uh oh!

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

hbrunn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants