Skip to content

[FIX] auth_api_key: Read API key from headers #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SirPyTech wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[FIX] auth_api_key: Read API key from headers #945

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions auth_api_key/models/ir_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ class IrHttp(models.AbstractModel):

@classmethod
def _auth_method_api_key(cls):
headers = request.httprequest.environ
api_key = headers.get("HTTP_API_KEY")
headers = request.httprequest.headers
api_key = headers.get("API_KEY")
if api_key:
request.update_env(user=1)
auth_api_key = request.env["auth.api.key"]._retrieve_api_key(api_key)
Expand Down
14 changes: 14 additions & 0 deletions auth_api_key/tests/test_auth_api_key.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
# Copyright 2018 ACSONE SA/NV
# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).

from werkzeug.datastructures import EnvironHeaders

from odoo.exceptions import AccessError, ValidationError
from odoo.tests.common import TransactionCase

from odoo.addons.website.tools import MockRequest


class TestAuthApiKey(TransactionCase):
@classmethod
Expand Down Expand Up @@ -68,3 +73,12 @@ def test_user_archived_unarchived_with_option_off(self):
self.assertEqual(
self.env["auth.api.key"]._retrieve_uid_from_api_key("api_key"), demo_user.id
)

def test_api_key_headers(self):
"""The API key in the headers is read."""
with MockRequest(self.env) as mocked_request:
mocked_request.httprequest.environ["HTTP_API_KEY"] = self.api_key_good.key
mocked_request.httprequest.headers = EnvironHeaders(
mocked_request.httprequest.environ
)
self.assertTrue(self.env["ir.http"]._auth_method_api_key())
Loading