[19.0][MIG] hr_timesheet_calendar: Migration to 19.0#898
Conversation
OCA-git-bot
added
series:19.0
mod:hr_timesheet_calendar
CRogos
force-pushed
the
copilot/migrate-hr-timesheet-calendar-18-to-19
branch
4 times, most recently
from
78bc892 to
7416726
Compare
|
@bizzappdev , @alexey-pelykh could you review, also the dependent PRs. |
MohamedOsman7
left a comment
MohamedOsman7
left a comment
There was a problem hiding this comment.
I encountered the following error when clicking on the calendar view:
ValueError: Cannot convert account.analytic.line.date_time_end to SQL because it is not stored.
This is because of this missing PR #896 as mentioned above. |
CRogos
force-pushed
the
copilot/migrate-hr-timesheet-calendar-18-to-19
branch
4 times, most recently
from
2fa0d61 to
e597b24
Compare
CRogos
force-pushed
the
copilot/migrate-hr-timesheet-calendar-18-to-19
branch
6 times, most recently
from
0909a90 to
d2b4886
Compare
CRogos
force-pushed
the
copilot/migrate-hr-timesheet-calendar-18-to-19
branch
2 times, most recently
from
71fb166 to
9521013
Compare
|
@MohamedOsman7 can be retested when #927 merged or hr_timesheet_time_control_begin_end is uninstalled. |
Currently translated at 100.0% (4 of 4 strings) Translation: timesheet-17.0/timesheet-17.0-hr_timesheet_calendar Translate-URL: https://translation.odoo-community.org/projects/timesheet-17-0/timesheet-17-0-hr_timesheet_calendar/it/
…ate configurable to be now or directly after the previous entry if available otherwise use employee working hour start
… dict Running tests, sometimes an error was raised when demo project has analytic account set. When was unset the problem was hidden.
… when using 'no-gap'
…add date_time assignment in create method
Port idea of OCA#812 in v18 [FIX]LINT
CRogos
force-pushed
the
copilot/migrate-hr-timesheet-calendar-18-to-19
branch
from
9521013 to
92d750c
Compare
|
Should work now, but for testing hr_timesheet_begin_end should be uninstalled, because there are some issues with the start/end time calculation. (installing hr_timesheet_time_control_begin_end and hr_timesheet_begin_end at the same time does not make sense anyway) |
|
@lbarry-apsl could you review? |
CRogos
force-pushed
the
copilot/migrate-hr-timesheet-calendar-18-to-19
branch
from
92d750c to
887bdbf
Compare
MohamedOsman7
left a comment
MohamedOsman7
left a comment
There was a problem hiding this comment.
Tested! Functional & Code LGTM
|
@leemannd could you review? |
7 participants
supersede: #842
This PR depends on #896 to work.
Tests fixed by #899
But it looks like it cannot be done via temporary reference