Skip to content

[ADD] hr_timesheet_amount_security: New module#912

Open
EmilioPascual wants to merge 1 commit into
OCA:18.0from
moduon:add-hr_timesheet_amount_security
Open

[ADD] hr_timesheet_amount_security: New module#912
EmilioPascual wants to merge 1 commit into
OCA:18.0from
moduon:add-hr_timesheet_amount_security

Conversation

@EmilioPascual

Copy link
Copy Markdown

Module for hide costs inside pivots in Timehseets > Reporting:

@rafaelbn @chienandalu @Gelojr could you review, plz?

MT-14618

@OCA-git-bot OCA-git-bot added series:18.0 mod:hr_timesheet_amount_security Module hr_timesheet_amount_security labels May 6, 2026

@fcvalgar fcvalgar left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this contribution @EmilioPascual.

The module is clear, focused, and correctly applies the analytic amount security group to protect sensitive cost fields while keeping the operational timesheet flows available.

I have performed the following functional tests:
Test 1: OK - A user without “Allow to read analytic costs” can access the timesheet analysis report but cannot see the Amount field.
Test 2: OK - A user with “Allow to read analytic costs” can see the Amount field in the timesheet analysis report.
Test 3: OK - A user without the permission cannot see Timesheets Cost, Attendance Cost, or Cost Difference in the timesheet attendance report.
Test 4: OK - A user with the permission can see the protected cost fields in the timesheet attendance report.
Test 5: OK - The module does not block the creation or consultation of regular timesheet entries.
Test 6: OK - Adding and removing the permission correctly changes the visibility of the protected fields.
Test 7: OK - The protected fields are correctly restricted through the expected analytic amount security group.

LGTM

@chienandalu chienandalu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review 👍

@OCA-git-bot

Copy link
Copy Markdown
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BhaveshHeliconia BhaveshHeliconia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants