[18.0][IMP] sale_timesheet_rounded: add rounded hours on tasks and sale orders#929
Open
thienvh332 wants to merge 1 commit into
Open
[18.0][IMP] sale_timesheet_rounded: add rounded hours on tasks and sale orders#929thienvh332 wants to merge 1 commit into
thienvh332 wants to merge 1 commit into
Conversation
OCA-git-bot
added
series:18.0
mod:sale_timesheet_rounded
thienvh332
force-pushed
the
18.0-imp-sale_timesheet_rounded
branch
from
23c2ecf to
f158cd4
Compare
divad1196
approved these changes
May 22, 2026
divad1196
left a comment
divad1196
left a comment
There was a problem hiding this comment.
Looks good.
Made a couple of remarks
- Split sale.py into sale_order_line.py and sale_order.py for clarity - Add computed fields on project.task: effective_hours_rounded, remaining_hours_rounded, total_hours_spent_rounded, subtask_effective_hours_rounded - Add timesheet_total_duration_rounded on sale.order to display rounded total beside actual total - Revamp project_task form view: replace flat hour summary with Actual / Rounded two-column table - Add kanban badge for remaining_hours_rounded - Add sale_order view showing "Recorded (Rounded / Actual)" in the timesheet stat button
thienvh332
force-pushed
the
18.0-imp-sale_timesheet_rounded
branch
from
f158cd4 to
e1c0b6d
Compare
cgarcia-solvos
approved these changes
May 29, 2026
cgarcia-solvos
left a comment
cgarcia-solvos
left a comment
Contributor
There was a problem hiding this comment.
Code and functional review. LGTM!
Contributor
|
This PR has the |
1 similar comment
Contributor
|
This PR has the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the
sale_timesheet_roundedmodule by exposing rounded timesheet values directly on tasks and sale orders, allowing users to compare actual and rounded hours more clearly across the project and sales flows.Main Changes
Task rounded-hour metrics
Added new computed fields on
project.task:effective_hours_rounded: rounded hours directly logged on the tasksubtask_effective_hours_rounded: recursive aggregation of rounded hours from child taskstotal_hours_spent_rounded: combined rounded hours from the task and its subtasksremaining_hours_rounded: remaining allocated hours based on rounded spent timeSale order rounded totals
Added a new computed field on
sale.order:timesheet_total_duration_rounded: aggregated rounded duration from all related analytic linesUI Improvements
Task form view
Reworked the time summary section to display side-by-side Actual vs Rounded values for:
Task kanban view
remaining_hoursbadge withremaining_hours_roundedSale order form
Rounded / Actualinstead of actual onlyRefactoring
Split
sale.pyinto:sale_order.pysale_order_line.pyto improve readability and separation of concerns.