[FIX][18.0] web_theme_classic: don't double-tint required monetary fields#3570
Merged
OCA-git-bot merged 1 commit intoJun 7, 2026
Conversation
Contributor
|
Hi @legalsylvain, |
Contributor
|
Not sure to understand what you want to fix. could you provide screenshots before / after ? |
Contributor
Author
|
@legalsylvain sorry - my bad. Updated the initial cooment with screenshots and code snippet. |
legalsylvain
reviewed
Jun 7, 2026
| "name": "Web Theme Classic", | ||
| "summary": "Contrasted style on fields to improve the UI.", | ||
| "version": "18.0.1.2.0", | ||
| "version": "18.0.1.2.1", |
Contributor
There was a problem hiding this comment.
That is not necessary.
The required-field background sets --o-input-background-color on every .o_input inside an o_required_modifier. A monetary field renders an absolutely-positioned overlay span (which also carries .o_input) on top of the real input, so the semi-transparent tint was applied to both and the overlap rendered as a darker band over the value. Keep the overlay background transparent so only the real input carries the required tint, in both form and list views. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Rad0van
force-pushed
the
18.0-fix-web_theme_classic-required-monetary-overlay
branch
from
7c867d4 to
f99f49b
Compare
Contributor
|
thanks. /ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at 3daf540. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required-field background sets
--o-input-background-coloron every.o_inputinside ano_required_modifier. A monetary field renders an absolutely-positioned overlay span (which also carries.o_input) on top of the real input, so the semi-transparent tint was applied to both and the overlap rendered as a darker band over the value.Keep the overlay background transparent so only the real input carries the required tint, in both form and list views.
Before:
After:
This is from delivery.carrier configuration where something like this is used: