Remove incorrect [Obsolete] from DataServiceContext.Timeout#3498
Draft
Remove incorrect [Obsolete] from DataServiceContext.Timeout#3498
[Obsolete] from DataServiceContext.Timeout#3498Conversation
…property Co-authored-by: xuzhg <9426627+xuzhg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue #3494
Remove incorrect Mar 8, 2026
[Obsolete] from DataServiceContext.Timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataServiceContext.Timeoutwas marked obsolete with a message directing users to "useIHttpClientFactory" — butIHttpClientFactoryis an interface, not a property, leaving no actionable migration path. The property is still fully functional: it sets a per-request timeout that flows throughRequestInfo→ODataRequestMessageWrapper→HttpClientRequestMessage.Timeout. The obsolete attribute also caused a CS0618 warning insideRequestInfo.cswhere the library callsthis.Context.Timeoutinternally.Changes
DataServiceContext.cs: Remove[Obsolete]fromTimeoutproperty; update XML docs to clarify:Timeoutremains the primary mechanismHttpClientFactorycan be used to configure a sharedHttpClient.Timeoutfor all requestsTimeouttakes precedence💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.