[Integrate-2600] Support notebook kernels offline installation#2702
Open
hengxian-jiang wants to merge 2 commits into
Open
[Integrate-2600] Support notebook kernels offline installation#2702hengxian-jiang wants to merge 2 commits into
hengxian-jiang wants to merge 2 commits into
Conversation
hengxian-jiang
requested review from
KangJingA,
SantanM,
p-hoffmann and
suwarnoong
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Adds build-time preparation and runtime configuration so the WebR notebook can load Pyodide/WebR kernel assets from the app’s own bundled resources (enabling offline/air‑gapped use).
Changes:
- Adds a Vite build plugin to prepare/copy offline kernel assets into the build output and injects a kernel asset base path at build time.
- Updates
NotebookManagerto derive kernel URLs viabuildKernelAssetUrls(supporting local/offline origins). - Introduces a build-time asset preparation script plus pure helper functions and unit tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/ui/apps/webr-notebook/vite.config.ts | Adds build-only offline asset preparation plugin and injects __KERNEL_ASSET_BASE__. |
| plugins/ui/apps/webr-notebook/src/components/NotebookManager.tsx | Switches kernel config to use computed offline/CDN asset URLs. |
| plugins/ui/apps/webr-notebook/scripts/prepare-offline-assets.mjs | New build-time script to stage Pyodide/WebR assets for offline runtime use. |
| plugins/ui/apps/webr-notebook/scripts/offline-assets-lib.mjs | Adds testable helper logic for dependency closure and PACKAGES filtering. |
| plugins/ui/apps/webr-notebook/scripts/offline-assets-lib.test.mjs | Adds node:test coverage for the helper utilities. |
| plugins/ui/apps/webr-notebook/package.json | Adds a script entry to run the offline asset preparation script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)Update submodule is required after PR merged