chore: Fix netlify deploy by updating various @babel dependencies.#6049
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThis PR upgrades Babel dependencies to 7.29.7 across the OHIF monorepo. ChangesBabel 7.29.7 alignment
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Actionable comments posted: 0 |
e3bd23a to
550b1d2
Compare
Context
Netlify was not auto-deploying to viewer-dev. The reason from Claude being...
Changes & Results
Updated various "@babel/*" packages to "7.29.7".
Testing
Automated tests should pass and Netlify viewer-dev deploy should work.
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Summary by CodeRabbit
Greptile Summary
This PR fixes the Netlify deploy failure caused by a Yarn 1 hoisting conflict between two co-resolved versions of
@babel/helper-create-class-features-plugin(7.27.1 and 7.28.6), which causedbuildNamedEvaluationVisitorto be missing at runtime. The fix aligns all direct@babel/*dependencies to7.29.7and removes the now-unnecessaryresolutionsoverrides, collapsing the helper to a single lockfile entry.@babel/*devDependencies and@babel/runtimeacross workspace packages are bumped uniformly to7.29.7, eliminating the version split that caused the build-time crash.resolutionsentries for@babel/runtime-corejs2,@babel/plugin-transform-modules-systemjs, and@babel/helper-create-class-features-pluginare removed from rootpackage.json; the helper entry is now correctly consolidated inyarn.lock.Confidence Score: 5/5
Safe to merge — the change is a targeted version alignment of Babel packages that directly resolves the confirmed Netlify build failure.
All changes are dependency version bumps to a single coherent 7.29.7 baseline. The root cause (split resolution of @babel/helper-create-class-features-plugin) is correctly fixed in yarn.lock. The removed resolutions overrides were workarounds that are no longer needed. No application logic is touched.
No files require special attention.
Important Files Changed
Comments Outside Diff (1)
yarn.lock, line 1 (link)@babel/plugin-transform-modules-systemjsAfter this PR,
yarn.lockstill resolves@babel/plugin-transform-modules-systemjsto two versions:7.29.4(for^7.27.1/^7.29.0) and7.29.7(for^7.29.7). The package was removed as a direct dep so it won't sit at the top-level under the old version the way the helper did, but Yarn 1 hoisting could still land one of these ahead of the other for transitive consumers. If any future caller targeting^7.29.7gets the wrong copy, you'd hit the same class of runtime mismatch. Bumping the^7.27.1/^7.29.0aliases to resolve to7.29.7as well (or adding aresolutionsentry for the package) would close this gap entirely.Prompt To Fix With AI
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Reviews (2): Last reviewed commit: "chore: Fix netlify deploy by updating va..." | Re-trigger Greptile