Skip to content

chore: Fix netlify deploy by updating various @babel dependencies.#6049

Merged
jbocce merged 1 commit into
OHIF:masterfrom
jbocce:fix/netlify-deploy
May 29, 2026
Merged

chore: Fix netlify deploy by updating various @babel dependencies.#6049
jbocce merged 1 commit into
OHIF:masterfrom
jbocce:fix/netlify-deploy

Conversation

@jbocce
Copy link
Copy Markdown
Collaborator

@jbocce jbocce commented May 28, 2026

Context

Netlify was not auto-deploying to viewer-dev. The reason from Claude being...

 That commit (on May 15, 2026) bumped @babel/preset-env from 7.28.0 → 7.29.5 in the root package.json. The new preset pulled in @babel/plugin-transform-class-static-block@7.28.6, which calls buildNamedEvaluationVisitor from @babel/helper-create-class-features-plugin. That function only exists in 7.28.x of the helper.

  Your current yarn.lock resolved the helper to two versions side-by-side (yarn.lock:194 and yarn.lock:207):

  - 7.28.6 for ^7.18.6 / ^7.21.0 / ^7.28.6
  - 7.27.1 for the bare ^7.27.1 requesters

  On Netlify, --pure-lockfile installs exactly that lock. Yarn 1 hoists 7.27.1 to the top-level node_modules/@babel/helper-create-class-features-plugin/ (because more callers want ^7.27.1), and the newer plugin at the top level resolves up to that older copy → buildNamedEvaluationVisitor is not a function.

Changes & Results

Updated various "@babel/*" packages to "7.29.7".

Testing

Automated tests should pass and Netlify viewer-dev deploy should work.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Summary by CodeRabbit

  • Chores
    • Updated the Babel compiler/transpiler toolchain and runtime across the project to 7.29.7, aligning plugins and presets for consistent builds.
    • Updated runtime versions across packages for consistency.
    • Removed unused Babel resolution overrides.

Review Change Stack

Greptile Summary

This PR fixes the Netlify deploy failure caused by a Yarn 1 hoisting conflict between two co-resolved versions of @babel/helper-create-class-features-plugin (7.27.1 and 7.28.6), which caused buildNamedEvaluationVisitor to be missing at runtime. The fix aligns all direct @babel/* dependencies to 7.29.7 and removes the now-unnecessary resolutions overrides, collapsing the helper to a single lockfile entry.

  • All @babel/* devDependencies and @babel/runtime across workspace packages are bumped uniformly to 7.29.7, eliminating the version split that caused the build-time crash.
  • Stale resolutions entries for @babel/runtime-corejs2, @babel/plugin-transform-modules-systemjs, and @babel/helper-create-class-features-plugin are removed from root package.json; the helper entry is now correctly consolidated in yarn.lock.

Confidence Score: 5/5

Safe to merge — the change is a targeted version alignment of Babel packages that directly resolves the confirmed Netlify build failure.

All changes are dependency version bumps to a single coherent 7.29.7 baseline. The root cause (split resolution of @babel/helper-create-class-features-plugin) is correctly fixed in yarn.lock. The removed resolutions overrides were workarounds that are no longer needed. No application logic is touched.

No files require special attention.

Important Files Changed

Filename Overview
package.json Bumps all @babel/* devDependencies to 7.29.7; removes @babel/runtime-corejs2, @babel/plugin-transform-modules-systemjs, and @babel/helper-create-class-features-plugin from resolutions—only @babel/helper-create-class-features-plugin was the root-cause override, now unified in yarn.lock.
yarn.lock @babel/helper-create-class-features-plugin is now resolved to a single 7.29.7 entry (fixing the original issue); a minor split on @babel/plugin-transform-modules-systemjs (7.29.4 vs 7.29.7) and @babel/generator (7.27.5 / 7.29.1 / 7.29.7) remain but were already flagged or are lower-risk transitive splits.
platform/app/package.json @babel/runtime bumped from 7.28.2 to 7.29.7 and @babel/plugin-transform-private-methods bumped to 7.29.7; straightforward version alignment.
platform/core/package.json @babel/runtime bumped from 7.28.2 to 7.29.7; no structural changes.

Comments Outside Diff (1)

  1. yarn.lock, line 1 (link)

    P2 Residual split on @babel/plugin-transform-modules-systemjs

    After this PR, yarn.lock still resolves @babel/plugin-transform-modules-systemjs to two versions: 7.29.4 (for ^7.27.1 / ^7.29.0) and 7.29.7 (for ^7.29.7). The package was removed as a direct dep so it won't sit at the top-level under the old version the way the helper did, but Yarn 1 hoisting could still land one of these ahead of the other for transitive consumers. If any future caller targeting ^7.29.7 gets the wrong copy, you'd hit the same class of runtime mismatch. Bumping the ^7.27.1 / ^7.29.0 aliases to resolve to 7.29.7 as well (or adding a resolutions entry for the package) would close this gap entirely.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: yarn.lock
    Line: 1
    
    Comment:
    **Residual split on `@babel/plugin-transform-modules-systemjs`**
    
    After this PR, `yarn.lock` still resolves `@babel/plugin-transform-modules-systemjs` to two versions: `7.29.4` (for `^7.27.1` / `^7.29.0`) and `7.29.7` (for `^7.29.7`). The package was removed as a direct dep so it won't sit at the top-level under the old version the way the helper did, but Yarn 1 hoisting could still land one of these ahead of the other for transitive consumers. If any future caller targeting `^7.29.7` gets the wrong copy, you'd hit the same class of runtime mismatch. Bumping the `^7.27.1` / `^7.29.0` aliases to resolve to `7.29.7` as well (or adding a `resolutions` entry for the package) would close this gap entirely.
    
    How can I resolve this? If you propose a fix, please make it concise.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Reviews (2): Last reviewed commit: "chore: Fix netlify deploy by updating va..." | Re-trigger Greptile

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 28, 2026

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 550b1d2
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/6a18d832eae2531b9c2dd01f
😎 Deploy Preview https://deploy-preview-6049--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

📝 Walkthrough

Walkthrough

This PR upgrades Babel dependencies to 7.29.7 across the OHIF monorepo. @babel/runtime is bumped from 7.28.2 to 7.29.7 in ~25 packages; several packages also align @babel/core, plugins, and presets to 7.29.7. Root package.json removes stale Yarn resolution pins.

Changes

Babel 7.29.7 alignment

Layer / File(s) Summary
Platform packages @babel/runtime update
platform/app/package.json, platform/cli/package.json, platform/core/package.json, platform/i18n/package.json, platform/ui/package.json, platform/ui-next/package.json
Platform subpackages update @babel/runtime and select Babel devDependencies to 7.29.7.
Extensions and modes @babel/runtime update
extensions/*/package.json, modes/*/package.json
Many extensions and modes update @babel/runtime to 7.29.7; selected packages (e.g., extensions/usAnnotation, modes/segmentation, modes/usAnnotation) also align @babel/core, plugin, and preset devDependencies to 7.29.7.
Add-on packages and root workspace configuration
addOns/externals/devDependencies/package.json, addOns/package.json, package.json
addOns and root workspace consolidate Babel dev toolchain to 7.29.7 and remove obsolete resolutions entries (@babel/runtime-corejs2, @babel/plugin-transform-modules-systemjs).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • OHIF/Viewers#6047: Updates root package.json Babel resolutions for @babel/helper-create-class-features-plugin; both PRs align Babel versions in resolutions.

Poem

🐰 I hopped through package trees today,
Bumped runtimes, presets — all in play.
Seven twenty-nine across each nest,
Plugins aligned for a cleaner quest.
Build hops onward — carrot-powered sway.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: updating Babel dependencies to fix a Netlify deployment issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description includes all required sections: Context (explaining the Netlify deploy failure), Changes & Results (listing dependency updates), Testing (describing validation approach), and a completed Checklist.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

Actionable comments posted: 0

@jbocce jbocce changed the title Fix/netlify deploy chore: Fix netlify deploy by updating various @babel dependencies. May 28, 2026
@jbocce jbocce force-pushed the fix/netlify-deploy branch from e3bd23a to 550b1d2 Compare May 28, 2026 23:53
@jbocce jbocce merged commit 9396e01 into OHIF:master May 29, 2026
9 checks passed
@jbocce jbocce deleted the fix/netlify-deploy branch May 29, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant