Skip to content

make X25519 & Ed25519 available for mbedtls configurations#5653

Merged
jforissier merged 1 commit intoOP-TEE:masterfrom
sa-kib:x25519-no-ltc
Dec 5, 2022
Merged

make X25519 & Ed25519 available for mbedtls configurations#5653
jforissier merged 1 commit intoOP-TEE:masterfrom
sa-kib:x25519-no-ltc

Conversation

@sa-kib
Copy link
Copy Markdown
Contributor

@sa-kib sa-kib commented Nov 16, 2022

Make LTC implementations of X25519 & Ed25519 algorithms available when crypto library is chosen to be mbedtls (which yet lacks support for these algorithms).

@jforissier
Copy link
Copy Markdown
Contributor

Make LTC implementations of X25519 & Ed25519 algorithms available when crypto library is chosen to be mbedtls (which yet lacks support for these algorithms).

That's fine (Acked-by: Jerome Forissier <jerome.forissier@linaro.org>), but wouldn't it make more sense to have this commit after some other commit actually adding/enabling support in MBed TLS ?

@sa-kib
Copy link
Copy Markdown
Contributor Author

sa-kib commented Dec 2, 2022

Make LTC implementations of X25519 & Ed25519 algorithms available when crypto library is chosen to be mbedtls (which yet lacks support for these algorithms).

That's fine (Acked-by: Jerome Forissier <jerome.forissier@linaro.org>), but wouldn't it make more sense to have this commit after some other commit actually adding/enabling support in MBed TLS ?

@jforissier this PR is actually a follow up of this discussion. Probably the commit description is a bit misleading, so I changed it for more clarity.

@jforissier
Copy link
Copy Markdown
Contributor

@sa-kib thanks for the update but I still find the commit description unclear. I'd like to make sure I understand well: this patch allows LibTomCrypt to be used for X25519/Ed25519 when MBedTLS is selected, correct? In this case how about:

crypto: fallback to LibTomCrypt for X25519/Ed25519 when CFG_CRYPTOLIB_NAME=mbedtls

Mbed TLS currently does not support X25519/Ed25519. This commit allows the
use of LibTomCrypt for these algorithms when CFG_CRYPTO_ED25519=y and/or
CFG_CRYPTO_X25519=y, and CFG_CRYPTOLIB_NAME=mbedtls.

…_NAME=mbedtls

Mbed TLS currently does not support X25519/Ed25519. This commit allows the
use of LTC implementation of these algorithms when CFG_CRYPTO_ED25519=y
and/or CFG_CRYPTO_X25519=y, and CFG_CRYPTOLIB_NAME=mbedtls.

Signed-off-by: Sergiy Kibrik <Sergiy_Kibrik@epam.com>
Acked-by: Jerome Forissier <jerome.forissier@linaro.org>
@sa-kib
Copy link
Copy Markdown
Contributor Author

sa-kib commented Dec 5, 2022

@sa-kib thanks for the update but I still find the commit description unclear. I'd like to make sure I understand well: this patch allows LibTomCrypt to be used for X25519/Ed25519 when MBedTLS is selected, correct? In this case how about:

crypto: fallback to LibTomCrypt for X25519/Ed25519 when CFG_CRYPTOLIB_NAME=mbedtls

Mbed TLS currently does not support X25519/Ed25519. This commit allows the
use of LibTomCrypt for these algorithms when CFG_CRYPTO_ED25519=y and/or
CFG_CRYPTO_X25519=y, and CFG_CRYPTOLIB_NAME=mbedtls.

I think your version describes what's going on very nice, I shall use it (only added word 'implementation' to clarify that only a part of LibTomCrypt gets enabled)

@jforissier jforissier merged commit 79243b1 into OP-TEE:master Dec 5, 2022
@sa-kib sa-kib deleted the x25519-no-ltc branch December 6, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants