Skip to content

Changed: Return type of virtual advanceStep() method #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kmokstad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Changed: Return type of virtual advanceStep() method #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions AdvectionDiffusion/AdvectionDiffusion.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,9 +223,6 @@ class AdvectionDiffusion : public IntegrandBase
//! \param[in] asol Pointer to analytical solution (optional)
NormBase* getNormIntegrand(AnaSol* asol) const override;

//! \brief Advances the integrand one time step forward.
virtual void advanceStep() {}

//! \brief Returns a reference to the fluid properties.
AD::FluidProperties& getFluidProperties() { return props; }
//! \brief Returns a const reference to the fluid properties.
Expand Down
2 changes: 1 addition & 1 deletion AdvectionDiffusion/AdvectionDiffusionBDF.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class AdvectionDiffusionBDF : public AdvectionDiffusion
}

//! \brief Advances the time stepping scheme.
void advanceStep() override { bdf.advanceStep(); }
bool advanceStep() override { return bdf.advanceStep(); }

//! \brief Returns a pointer to an Integrand for solution norm evaluation.
//! \note The Integrand object is allocated dynamically and has to be deleted
Expand Down