Skip to content

Changed: advanceStep() is now a virtual override returning true #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmokstad merged 1 commit into from
Aug 27, 2026
Merged

Changed: advanceStep() is now a virtual override returning true #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Darcy/DarcyBase.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ class DarcyBase : public HasGravityBase
void setMode(SIM::SolutionMode mode) override;

//! \brief Update time stepping scheme (BE -> BDF2 transition).
void advanceStep() { bdf.advanceStep(); }
bool advanceStep() override { return bdf.advanceStep(); }

using HasGravityBase::getLocalIntegral;
//! \brief Returns a local integral contribution object for given element.
Expand Down
5 changes: 2 additions & 3 deletions Darcy/SIMDarcy.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,10 +339,9 @@ bool SIMDarcy<Dim>::solveStep (const TimeStep& tp)
template<class Dim>
bool SIMDarcy<Dim>::advanceStep (TimeStep&)
{
if (drc.getOrder() > 0) {
drc.advanceStep();
if (drc.advanceStep())
this->pushSolution();
}

return true;
}

Expand Down
4 changes: 2 additions & 2 deletions Darcy/SIMDarcyAdvection.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,8 @@ bool SIMDarcyAdvection<Dim>::solveStep (const TimeStep& tp, bool forceNewTan)
template<class Dim>
bool SIMDarcyAdvection<Dim>::advanceStep (TimeStep&)
{
drc.advanceStep();
this->pushSolution();
if (drc.advanceStep())
this->pushSolution();

return true;
}
Expand Down