Add missing restart serialization - #7376
Draft
akva2 wants to merge 6 commits into
Draft
Conversation
Move the auto-choke group THP cache into the generic network base used by the well-model serializer. The derived network implementation accesses the inherited state, so the dynamic values now survive serialized restart.
Persist the FlowProblem first_step_ flag across serialized restarts. It controls the first-step explicit-quantity update path and otherwise resets to true when a problem is reconstructed.
WELPI scaling changes connection transmissibility factors after the well completion data has been constructed. Those scaled factors are copied into well_perf_data_ and then used as well_index_ when computing perforation transmissibilities and rates. They are runtime state, not merely static schedule metadata. The well model serializer previously omitted well_perf_data_. A restarted model therefore rebuilt perforation data from the schedule connection CF values, losing the scaled CTF values. This changed Tw immediately after restart and caused the local well equations and rates to diverge from a continuous run. Serialize all PerforationData fields so the restarted model restores the same completion factors and associated metadata. Add the PerforationData serialization test object, equality operator, double and conditional float instantiations, and cover the round trip through the existing RestartSerialization test macro.
akva2
added
the
manual:irrelevant
Member
Author
|
jenkins build this please |
Member
Author
|
last commit might not be necessary, drafting until i have verified |
akva2
marked this pull request as draft
August 31, 2026 11:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various dynamic state that was missing from restart serialization.