Skip to content

Properly fall back to potentials and avoid violating targets #7380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vkip wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Properly fall back to potentials and avoid violating targets #7380

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58d0247
Properly fall back to potentials when necessary and avoid violating t…
vkip Sep 1, 2026
844ae10
Avoid divide by zero in case of no active groups
vkip Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion opm/simulators/wells/FractionCalculator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,11 @@ localFraction(const std::string& name,
const Scalar my_total_pot = guideRateSum(parent_group, always_included_child, always_use_potentials).first;
// if there are no wells on group-control, potential will still be zero
if (my_total_pot == 0) {
return 1.0;
// No information at all to distribute the parent's target. Share it
// equally between the active members: returning 1.0 here would hand
// the full group target to every single member and thus violate the
// group (GCONPROD) target by a factor equal to the number of members.
return Scalar(1.0) / std::max(Scalar(1.0), Scalar(num_active_groups));
}

return my_pot / my_total_pot;
Expand Down Expand Up @@ -173,6 +177,14 @@ guideRate(const std::string& name,
const bool always_use_potentials)
{
if (schedule_.hasWell(name, report_step_)) {
if (always_use_potentials) {
// Fall back to the well potentials. Without this, a well that has a
// GUIDERAT/WGRUPCON guide rate would keep returning that (zero)
// guide rate here, so the potential based fallback in
// localFraction() would be a no-op and every well would end up with
// a fraction of 1.0.
return guide_rate_->getPotential(name, target_);
}
if (guide_rate_->has(name) || guide_rate_->hasPotentials(name)) {
return guide_rate_->get(name, target_, this->groupStateHelper().getWellRateVector(name));
}
Expand Down