Reorganize profile section: Categorized Accordion Layout for Profiles & Scan Methods #1474
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -213,22 +213,83 @@ def profiles(): | |||||
| Returns: | ||||||
| HTML content or available profiles | ||||||
| """ | ||||||
| all_profiles = Nettacker.load_profiles() | ||||||
| if "all" in all_profiles: | ||||||
| del all_profiles["all"] | ||||||
| if "..." in all_profiles: | ||||||
| del all_profiles["..."] | ||||||
|
|
||||||
| categories = { | ||||||
| "scan": { | ||||||
| "title": _("scan_modules_title"), | ||||||
| "desc": _("scan_modules_desc"), | ||||||
| "label": "success", | ||||||
| "profiles": [], | ||||||
| }, | ||||||
| "brute": { | ||||||
| "title": _("brute_modules_title"), | ||||||
| "desc": _("brute_modules_desc"), | ||||||
| "label": "warning", | ||||||
| "profiles": [], | ||||||
| }, | ||||||
| "vuln": { | ||||||
| "title": _("vuln_modules_title"), | ||||||
| "desc": _("vuln_modules_desc"), | ||||||
| "label": "danger", | ||||||
| "profiles": [], | ||||||
| }, | ||||||
| } | ||||||
|
|
||||||
| for profile in sorted(all_profiles.keys()): | ||||||
| modules = all_profiles[profile] | ||||||
| cats = set(m.split("_")[-1] for m in modules) | ||||||
|
|
||||||
| for cat in cats: | ||||||
| if cat in categories: | ||||||
| categories[cat]["profiles"].append(profile) | ||||||
| elif cat == "vulnerability" or cat == "vuln": | ||||||
| categories["vuln"]["profiles"].append(profile) | ||||||
|
|
||||||
| # Dedup and sort | ||||||
| for cat in categories: | ||||||
| categories[cat]["profiles"] = sorted(list(set(categories[cat]["profiles"]))) | ||||||
|
|
||||||
| res = """ | ||||||
| <div class="panel-group" id="profile_accordion"> | ||||||
| """ | ||||||
| for cat_name, cat_info in categories.items(): | ||||||
| res += """ | ||||||
| <div class="panel panel-default"> | ||||||
| <div class="panel-heading" style="cursor: pointer;" data-toggle="collapse" data-parent="#profile_accordion" href="#collapse_{0}"> | ||||||
|
There was a problem hiding this comment. The collapse toggle is implemented by putting an Prefer
Suggested change
|
||||||
| <h4 class="panel-title"> | ||||||
| <i class="fa fa-chevron-right"></i> | ||||||
| <span class="label label-{1}" style="margin-right: 10px;">{2}</span> | ||||||
| <small>{3}</small> | ||||||
| <label class="pull-right" onclick="event.stopPropagation();"> | ||||||
| <input type="checkbox" class="check-all-category" data-category="{0}"> | ||||||
| <small>{4}</small> | ||||||
| </label> | ||||||
| </h4> | ||||||
| </div> | ||||||
| <div id="collapse_{0}" class="panel-collapse collapse"> | ||||||
| <div class="panel-body text-justify"> | ||||||
| """.format( | ||||||
| cat_name, cat_info["label"], cat_info["title"], cat_info["desc"], _("select_all") | ||||||
| ) | ||||||
|
|
||||||
| for profile in cat_info["profiles"]: | ||||||
| label_type = cat_info["label"] | ||||||
| res += """ | ||||||
| <label><input id="{0}" type="checkbox" class="checkbox checkbox-{1}-profile" data-modules="{3}"> | ||||||
|
There was a problem hiding this comment. Profiles that belong to multiple categories are rendered once per category using the same Use unique ids per rendered checkbox (e.g., prefix/suffix with the category) and store the actual profile name in a separate attribute (
Suggested change
|
||||||
| <a class="label label-{2}">{0}</a></label> | ||||||
| """.format(profile, cat_name, label_type, ",".join(all_profiles[profile])) | ||||||
|
Comment on lines
+282
to
+285
There was a problem hiding this comment.
Escape values used in attributes/text (e.g., via |
||||||
|
|
||||||
| res += """ | ||||||
| </div> | ||||||
| </div> | ||||||
| </div> | ||||||
| """ | ||||||
| res += "</div>" | ||||||
| return res | ||||||
|
|
||||||
|
|
||||||
|
|
@@ -240,29 +301,71 @@ def scan_methods(): | |||||
| HTML content or available modules | ||||||
| """ | ||||||
| methods = Nettacker.load_modules() | ||||||
| if "all" in methods: | ||||||
| methods.pop("all") | ||||||
|
|
||||||
| categories = { | ||||||
| "scan": { | ||||||
| "title": _("scan_modules_title"), | ||||||
| "desc": _("scan_modules_desc"), | ||||||
| "label": "success", | ||||||
| "modules": [], | ||||||
| }, | ||||||
| "brute": { | ||||||
| "title": _("brute_modules_title"), | ||||||
| "desc": _("brute_modules_desc"), | ||||||
| "label": "warning", | ||||||
| "modules": [], | ||||||
| }, | ||||||
| "vuln": { | ||||||
| "title": _("vuln_modules_title"), | ||||||
| "desc": _("vuln_modules_desc"), | ||||||
| "label": "danger", | ||||||
| "modules": [], | ||||||
| }, | ||||||
| } | ||||||
|
|
||||||
| for sm in sorted(methods.keys()): | ||||||
| cat = sm.split("_")[-1] | ||||||
| if cat in categories: | ||||||
| categories[cat]["modules"].append(sm) | ||||||
| elif cat == "vulnerability": | ||||||
| categories["vuln"]["modules"].append(sm) | ||||||
|
|
||||||
| res = """ | ||||||
| <div class="panel-group" id="scan_methods_accordion"> | ||||||
| """ | ||||||
| for cat_name, cat_info in categories.items(): | ||||||
| res += """ | ||||||
| <div class="panel panel-default"> | ||||||
| <div class="panel-heading" style="cursor: pointer;" data-toggle="collapse" data-parent="#scan_methods_accordion" href="#collapse_sm_{0}"> | ||||||
|
There was a problem hiding this comment. Same issue as above for scan methods:
Suggested change
|
||||||
| <h4 class="panel-title"> | ||||||
| <i class="fa fa-chevron-right"></i> | ||||||
| <span class="label label-{1}" style="margin-right: 10px;">{2}</span> | ||||||
| <small>{3}</small> | ||||||
| <label class="pull-right" onclick="event.stopPropagation();"> | ||||||
| <input type="checkbox" class="check-all-sm-category" data-category="{0}"> | ||||||
| <small>{4}</small> | ||||||
| </label> | ||||||
| </h4> | ||||||
| </div> | ||||||
| <div id="collapse_sm_{0}" class="panel-collapse collapse"> | ||||||
| <div class="panel-body text-justify"> | ||||||
| """.format( | ||||||
| cat_name, cat_info["label"], cat_info["title"], cat_info["desc"], _("select_all") | ||||||
| ) | ||||||
|
|
||||||
| for module in cat_info["modules"]: | ||||||
| label_type = cat_info["label"] | ||||||
| res += """ | ||||||
| <label><input id="{0}" type="checkbox" class="checkbox checkbox-sm-{1}-module"> | ||||||
| <a class="label label-{2}">{0}</a></label> | ||||||
| """.format(module, cat_name, label_type) | ||||||
|
Comment on lines
+360
to
+363
There was a problem hiding this comment. Module names are interpolated into HTML ( Consider applying HTML/attribute escaping when rendering |
||||||
|
|
||||||
| res += """ | ||||||
| </div> | ||||||
| </div> | ||||||
| </div> | ||||||
| """ | ||||||
| res += "</div>" | ||||||
| return res | ||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -350,20 +350,30 @@ $(document).ready(function () { | |
| // profiles | ||
| var p = []; | ||
| var n = 0; | ||
| $("#profiles input[type='checkbox']:checked").each(function () { | ||
| if ( | ||
| this.id !== "all_profiles" && | ||
| !$(this).hasClass("check-all-category") | ||
| ) { | ||
| p[n] = this.id; | ||
| n += 1; | ||
| } | ||
| }); | ||
| // Deduplicate profiles as they might appear in multiple categories | ||
| p = Array.from(new Set(p)); | ||
| var profiles = p.join(","); | ||
|
Comment on lines
+353
to
364
There was a problem hiding this comment. The profile collection logic relies on Once profile checkboxes use unique DOM ids, collect the logical profile identifier from a dedicated attribute ( |
||
|
|
||
| // scan_methods | ||
| n = 0; | ||
| sm = []; | ||
| $("#selected_modules input[type='checkbox']:checked").each(function () { | ||
| if ( | ||
| this.id !== "all" && | ||
| !$(this).hasClass("check-all-sm-category") | ||
| ) { | ||
| sm[n] = this.id; | ||
| n += 1; | ||
| } | ||
| }); | ||
| var selected_modules = sm.join(","); | ||
| // language | ||
|
|
@@ -666,48 +676,137 @@ $(document).ready(function () { | |
| $(".checkbox").prop("checked", $(this).prop("checked")); | ||
| }); | ||
|
|
||
| $(document).on("change", "#profiles input[type='checkbox']", function () { | ||
| if ($(this).hasClass("check-all-category") || this.id === "all_profiles") { | ||
| return; | ||
| } | ||
| var modules = $(this).data("modules").split(","); | ||
| var isChecked = $(this).prop("checked"); | ||
| for (var i = 0; i < modules.length; i++) { | ||
| var moduleId = modules[i]; | ||
| if (isChecked) { | ||
| $("#" + moduleId).prop("checked", true); | ||
| } else { | ||
| // Only uncheck if no other checked profile includes this module | ||
| var stillNeeded = false; | ||
| $("#profiles input[type='checkbox']:checked").each(function () { | ||
| if ( | ||
| this.id !== "all_profiles" && | ||
| !$(this).hasClass("check-all-category") | ||
| ) { | ||
| var otherModules = $(this).data("modules").split(","); | ||
| if (otherModules.indexOf(moduleId) !== -1) { | ||
| stillNeeded = true; | ||
| return false; | ||
| } | ||
| } | ||
| }); | ||
| if (!stillNeeded) { | ||
| $("#" + moduleId).prop("checked", false); | ||
| } | ||
| } | ||
| } | ||
| }); | ||
|
Comment on lines
+679
to
709
Contributor
There was a problem hiding this comment. Potential error if At line 683, This could occur if:
🛡️ Defensive fix $(document).on("change", "#profiles input[type='checkbox']", function () {
if ($(this).hasClass("check-all-category") || this.id === "all_profiles") {
return;
}
- var modules = $(this).data("modules").split(",");
+ var modulesData = $(this).data("modules");
+ if (!modulesData) return;
+ var modules = modulesData.split(",");
var isChecked = $(this).prop("checked");
for (var i = 0; i < modules.length; i++) {
var moduleId = modules[i];
if (isChecked) {
$("#" + moduleId).prop("checked", true);
} else {
// Only uncheck if no other checked profile includes this module
var stillNeeded = false;
$("#profiles input[type='checkbox']:checked").each(function () {
if (
this.id !== "all_profiles" &&
!$(this).hasClass("check-all-category")
) {
- var otherModules = $(this).data("modules").split(",");
+ var otherData = $(this).data("modules");
+ if (!otherData) return true; // continue
+ var otherModules = otherData.split(",");
if (otherModules.indexOf(moduleId) !== -1) {
stillNeeded = true;
return false;
}
}
});🤖 Prompt for AI Agents |
||
|
|
||
| $(".checkbox-brute-profile").click(function () { | ||
| if (this.id === "brute") { | ||
| $(".checkbox-sm-brute-module").prop("checked", $(this).prop("checked")); | ||
| } | ||
| }); | ||
|
|
||
| $(".checkbox-scan-profile").click(function () { | ||
| if (this.id === "scan") { | ||
| $(".checkbox-sm-scan-module").prop("checked", $(this).prop("checked")); | ||
| } | ||
| }); | ||
|
|
||
| $(".checkbox-vuln-profile").click(function () { | ||
| if (this.id === "vulnerability" || this.id === "vuln") { | ||
| $(".checkbox-sm-vuln-module").prop("checked", $(this).prop("checked")); | ||
| } | ||
| }); | ||
|
Comment on lines
+711
to
727
There was a problem hiding this comment. These handlers run for every profile checkbox in the category but only do something when the checkbox id happens to be exactly Consider removing these click handlers and (if needed) implement any special “select all modules” behavior via the existing category-level checkboxes or within the single
Comment on lines
+711
to
727
Contributor
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# Check if any module yaml files define profiles with these exact names
rg -l '"scan"|"brute"|"vuln"|"vulnerability"' --type yaml nettacker/modules/ | head -20
# Also check the profile loading logic
rg -n 'profiles.*=.*\[' nettacker/modules/ --type yaml | grep -E '"(scan|brute|vuln|vulnerability)"' | head -10Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Find HTML templates that might define profiles
fd -type f -name "*.html" nettacker/web/ | head -20Repository: OWASP/Nettacker Length of output: 229 🏁 Script executed: # Search for where profiles are defined or listed
rg -n "profile" nettacker/web/static/js/main.js -A 2 -B 2 | head -50Repository: OWASP/Nettacker Length of output: 1597 🏁 Script executed: # Look for checkbox elements with IDs mentioned in the review
rg -n "checkbox.*brute|checkbox.*scan|checkbox.*vuln|id.*=.*['\"]brute['\"]|id.*=.*['\"]scan['\"]" nettacker/web/ --type html --type jsRepository: OWASP/Nettacker Length of output: 1242 🏁 Script executed: # Check if there are any profile-related data structures or definitions
rg -n "brute.*profile|scan.*profile|profile.*brute|profile.*scan" nettacker/web/ -A 2 -B 2 | head -40Repository: OWASP/Nettacker Length of output: 754 🏁 Script executed: # Find the HTML file that contains the profile checkboxes
fd -type f -name "*.html" nettacker/web/Repository: OWASP/Nettacker Length of output: 229 🏁 Script executed: # Look at the index.html file to see how profiles are structured
rg -n "checkbox.*profile|profiles" nettacker/web/static/index.html -A 3 -B 1 | head -80Repository: OWASP/Nettacker Length of output: 503 🏁 Script executed: # Check if there are template files that generate these checkboxes
fd -type f -name "*.html" nettacker/web/templates/Repository: OWASP/Nettacker Length of output: 229 🏁 Script executed: # Find Python files that might define or render profiles
fd -type f -name "*.py" nettacker/web/Repository: OWASP/Nettacker Length of output: 229 🏁 Script executed: # Search for where the profile variable is generated in Python
rg -n "profile.*=" nettacker/web/ -A 2 | head -100Repository: OWASP/Nettacker Length of output: 1893 🏁 Script executed: # Look for profile definitions or profile data
rg -n "profiles\s*=" nettacker/ --include="*.py" -A 5 | head -60Repository: OWASP/Nettacker Length of output: 500 🏁 Script executed: # Find Python files in nettacker/web
find nettacker/web -name "*.py"Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Search for where the profile template variable is set
rg -n "profile\"\|\"profile" nettacker/web/ -A 3Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Look for Flask/Django views that render the index template
rg -n "render.*profile\|profile.*render" nettacker/web/ -A 2Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Let's look at the actual index.html file to see the full profile section
cat nettacker/web/static/index.html | grep -A 100 "id=\"profiles\"" | head -120Repository: OWASP/Nettacker Length of output: 5305 🏁 Script executed: # Find all Python files in the web directory
find nettacker/web -name "*.py" -type fRepository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Search more broadly for where profiles are generated
rg "profile\s*=" nettacker/ -lRepository: OWASP/Nettacker Length of output: 114 🏁 Script executed: # Look at the engine.py file to see how profiles are generated
rg -n "profile" nettacker/api/engine.py -B 2 -A 2 | head -60Repository: OWASP/Nettacker Length of output: 330 🏁 Script executed: # Search for the web views/routes that render the index template
find nettacker -name "*.py" -path "*/web/*" -type f | xargs grep -l "render\|template\|index"Repository: OWASP/Nettacker Length of output: 43 🏁 Script executed: # Look for where the profile HTML is generated
rg -n "checkbox.*profile\|checkbox-brute\|checkbox-scan\|checkbox-vuln" nettacker/Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Find where the profiles() function is defined
rg -n "def profiles" nettacker/Repository: OWASP/Nettacker Length of output: 100 🏁 Script executed: # Check the imports in engine.py to see where profiles comes from
head -50 nettacker/api/engine.py | rg -n "from\|import"Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Search for profile generation across the codebase
rg -n "def profiles\|profiles\s*=" nettacker/ -A 5Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Look at the profiles() function implementation
sed -n '209,300p' nettacker/api/core.pyRepository: OWASP/Nettacker Length of output: 3127 🏁 Script executed: # Check the entire profiles() function
rg -n "def profiles" nettacker/api/core.py -A 80Repository: OWASP/Nettacker Length of output: 3311 🏁 Script executed: # Look for actual profile names in the modules
find nettacker/modules -name "*.py" -type f | head -5Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Check what actual profiles exist
rg -n "load_profiles\|all_profiles\|profile.*=" nettacker/api/core.py -B 5 -A 10 | head -60Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Get the Nettacker class definition to understand profile loading
rg -n "class Nettacker\|def load_profiles" nettacker/ -A 20 | head -80Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Find where Nettacker class is defined
find nettacker -name "*.py" -type f | xargs grep -l "class Nettacker"Repository: OWASP/Nettacker Length of output: 80 🏁 Script executed: # Search for .py files that might define profiles
find nettacker/modules -name "*.py" | head -10Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Look for JSON or YAML profile definitions
find nettacker -name "*.json" -o -name "*.yaml" -o -name "*.yml" | head -20Repository: OWASP/Nettacker Length of output: 561 🏁 Script executed: # Look at the Nettacker class in app.py
rg -n "def load_profiles\|class Nettacker" nettacker/core/app.py -A 30 | head -100Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Search for any configuration files that might list profiles
find nettacker -name "profiles*" -o -name "*profile*" | grep -v "__pycache__" | grep -v ".pyc"Repository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Look for where profiles are actually stored or referenced
rg -n "\"drupal\"\|\"wordpress\"\|\"ssl\"" nettacker/ -lRepository: OWASP/Nettacker Length of output: 41 🏁 Script executed: # Look at the check-all-category handler that the review mentions
rg -n "check-all-category" nettacker/web/static/js/main.js -B 2 -A 10Repository: OWASP/Nettacker Length of output: 2165 🏁 Script executed: # Examine the full context around lines 711-727 and 739-745
sed -n '705,750p' nettacker/web/static/js/main.jsRepository: OWASP/Nettacker Length of output: 1401 Remove these dead code click handlers or refactor for actual use. These handlers check conditions like Category-level selection is already handled properly by the 🤖 Prompt for AI Agents |
||
|
|
||
| $(".check-all-profiles").click(function () { | ||
| var isChecked = $(this).prop("checked"); | ||
| $("#profiles input[type='checkbox']") | ||
| .not(this) | ||
| .not(".check-all-category") | ||
| .prop("checked", isChecked) | ||
| .trigger("change"); | ||
| $(".check-all-category").prop("checked", isChecked); | ||
| }); | ||
|
|
||
| $(document).on("change", ".check-all-category", function () { | ||
| var category = $(this).data("category"); | ||
| var isChecked = $(this).prop("checked"); | ||
| $(".checkbox-" + category + "-profile") | ||
| .prop("checked", isChecked) | ||
| .trigger("change"); | ||
| }); | ||
|
|
||
| $(document).on("show.bs.collapse", "#profile_accordion", function (e) { | ||
| $(e.target) | ||
| .prev(".panel-heading") | ||
| .find(".fa") | ||
| .removeClass("fa-chevron-right") | ||
| .addClass("fa-chevron-down"); | ||
| }); | ||
|
|
||
| $(document).on("hide.bs.collapse", "#profile_accordion", function (e) { | ||
| $(e.target) | ||
| .prev(".panel-heading") | ||
| .find(".fa") | ||
| .removeClass("fa-chevron-down") | ||
| .addClass("fa-chevron-right"); | ||
| }); | ||
|
|
||
| $(".check-all-scans").click(function () { | ||
| $("#selected_modules input[type='checkbox']").not(this).prop("checked", $(this).prop("checked")); | ||
| $(".check-all-sm-category").prop("checked", $(this).prop("checked")); | ||
| }); | ||
|
|
||
| $(document).on("change", ".check-all-sm-category", function () { | ||
| var category = $(this).data("category"); | ||
| $(".checkbox-sm-" + category + "-module").prop("checked", $(this).prop("checked")); | ||
| }); | ||
|
|
||
| $(document).on("show.bs.collapse", "#scan_methods_accordion", function (e) { | ||
| $(e.target) | ||
| .prev(".panel-heading") | ||
| .find(".fa") | ||
| .removeClass("fa-chevron-right") | ||
| .addClass("fa-chevron-down"); | ||
| }); | ||
|
|
||
| $(document).on("hide.bs.collapse", "#scan_methods_accordion", function (e) { | ||
| $(e.target) | ||
| .prev(".panel-heading") | ||
| .find(".fa") | ||
| .removeClass("fa-chevron-down") | ||
| .addClass("fa-chevron-right"); | ||
| }); | ||
|
|
||
| $(document).on("click", ".checkbox-sm-vuln-module", function () { | ||
| if (!$(this).is(":checked")) { | ||
| $(".checkAll").prop("checked", false); | ||
| $("#vulnerability").prop("checked", false); | ||
| $("#vuln").prop("checked", false); | ||
| $(".check-all-scans").prop("checked", false); | ||
| } | ||
| }); | ||
|
|
||
| $(document).on("click", ".checkbox-sm-scan-module", function () { | ||
| if (!$(this).is(":checked")) { | ||
| $(".checkAll").prop("checked", false); | ||
| $("#scan").prop("checked", false); | ||
| $(".check-all-scans").prop("checked", false); | ||
| } | ||
| }); | ||
|
|
||
| $(document).on("click", ".checkbox-sm-brute-module", function () { | ||
| if (!$(this).is(":checked")) { | ||
| $(".checkAll").prop("checked", false); | ||
| $("#brute").prop("checked", false); | ||
| $(".check-all-scans").prop("checked", false); | ||
| } | ||
| }); | ||
|
Comment on lines
+789
to
812
Contributor
There was a problem hiding this comment. References to non-existent element IDs These handlers attempt to uncheck elements with IDs These 🔧 Proposed fix - use category checkbox selectors $(document).on("click", ".checkbox-sm-vuln-module", function () {
if (!$(this).is(":checked")) {
$(".checkAll").prop("checked", false);
- $("#vulnerability").prop("checked", false);
- $("#vuln").prop("checked", false);
+ $(".check-all-sm-category[data-category='vuln']").prop("checked", false);
$(".check-all-scans").prop("checked", false);
}
});
$(document).on("click", ".checkbox-sm-scan-module", function () {
if (!$(this).is(":checked")) {
$(".checkAll").prop("checked", false);
- $("#scan").prop("checked", false);
+ $(".check-all-sm-category[data-category='scan']").prop("checked", false);
$(".check-all-scans").prop("checked", false);
}
});
$(document).on("click", ".checkbox-sm-brute-module", function () {
if (!$(this).is(":checked")) {
$(".checkAll").prop("checked", false);
- $("#brute").prop("checked", false);
+ $(".check-all-sm-category[data-category='brute']").prop("checked", false);
$(".check-all-scans").prop("checked", false);
}
});🤖 Prompt for AI Agents |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: OWASP/Nettacker
Length of output: 5248
🏁 Script executed:
sed -n '222,241p' nettacker/api/core.pyRepository: OWASP/Nettacker
Length of output: 622
🏁 Script executed:
sed -n '243,260p' nettacker/api/core.pyRepository: OWASP/Nettacker
Length of output: 701
Module suffix mismatch causes silent exclusion from profile categorization.
The category derivation logic at line 245 (
m.split("_")[-1]) extracts the last underscore-separated segment. However, the code only recognizes specific suffixes: "scan", "brute", "vuln", or "vulnerability" (lines 247-249). Modules with other suffixes (e.g.,"wp_xmlrpc_bruteforce"→ "bruteforce","ssl_weak_version"→ "version") are silently skipped and will not appear in the profile accordion UI. Over 180 existing modules are affected by this.🤖 Prompt for AI Agents