Skip to content

Fix translation for compare_scans message #1480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Vineshnayak wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix translation for compare_scans message #1480

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
650d568
Fix translation for compare_scans message
Vineshnayak Mar 31, 2026
f10e644
Merge branch 'master' into patch-1
Vineshnayak Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nettacker/locale/hi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ start_parallel_module_scan: प्रक्रिया- {0} | {1} | {2} |{4}
thread_number_modules: मेजबान के लिए समानांतर मॉड्यूल स्कैन
wrong_hardware_usage: "आपको हार्डवेयर उपयोग के लिए इनमें से एक प्रोफाइल का चयन करना होगा। (low, normal, high, maximum)"
invalid_scan_id: आपकी स्कैन आईडी मान्य नहीं है
compare_scans: scan_id का उपयोग करके वर्तमान स्कैन की पुराने स्कैन से तुलना करें
compare_scans: "scan_id का उपयोग करके वर्तमान स्कैन की तुलना पुराने स्कैन से करें"
compare_report_path_filename: तुलना रिपोर्ट सहेजने का फ़ाइल पथ
no_scan_to_compare: तुलना करने के लिए scan_id नहीं मिला
compare_report_saved: "{0} में तुलना परिणाम सहेजे गए"
build_compare_report: "तुलना रिपोर्ट बनाई जा रही है"
finish_build_report: "तुलना रिपोर्ट तैयार हो गई"
finish_build_report: "तुलना रिपोर्ट तैयार हो गई"
Comment on lines +120 to +125
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify signature status for commits in this PR branch vs master
git log --pretty=format:'%h %G? %an %s' origin/master..HEAD

# Expected: signed commits (typically G/U depending on trust state).
# Investigate any N/B/E/X/Y/R statuses as unsigned/invalid signatures.

Repository: OWASP/Nettacker

Length of output: 189

All commits in this PR must be GPG signed before merge.

@Vineshnayak: The commit in this PR is currently unsigned. This PR will fail pre-merge checks and cannot be merged until you sign the commit(s).

To fix this:

  1. Sign the commit: git commit --amend -S
  2. Force-push the updated history: git push --force-with-lease

Alternatively, if you have multiple unsigned commits, you can use an interactive rebase to sign them all:

git rebase --exec 'git commit --amend -S --no-edit' origin/master
git push --force-with-lease

Signed commits are a mandatory requirement in this repository.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@nettacker/locale/hi.yaml` around lines 120 - 125, The commits that modified
the locale keys (compare_scans, compare_report_path_filename,
no_scan_to_compare, compare_report_saved, build_compare_report,
finish_build_report) are unsigned and must be GPG-signed before merging; fix
this by signing the commit(s) (e.g., run git commit --amend -S for the latest
commit or use git rebase --exec 'git commit --amend -S --no-edit' origin/master
to sign multiple commits), then push the rewritten history with git push
--force-with-lease so the pre-merge checks pass.

Loading