Skip to content

fix(docker): include LICENSE in runtime image for Apache-2.0 attribution #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aenawi wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(docker): include LICENSE in runtime image for Apache-2.0 attribution #1520

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b390d6
fix(docker): include LICENSE in runtime image for Apache-2.0 attribution
aenawi Apr 18, 2026
4b8e0db
Merge branch 'master' into fix/dockerfile-include-license-in-runtime-…
securestep9 Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ ENV PATH=/usr/src/owaspnettacker/.venv/bin:$PATH
RUN pip install --no-deps --no-cache-dir nettacker-*.whl && \
rm -f nettacker-*.whl

### Preserve Apache-2.0 license text in the final image for downstream attribution
COPY LICENSE ./

Comment on lines +50 to +52
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify PR template sections and commit signature status for PR 1520 (read-only)

set -euo pipefail

echo "== PR body =="
gh pr view 1520 --repo OWASP/Nettacker --json body,author,url \
  --jq '.url + "\nAuthor: @" + .author.login + "\n\n" + .body'

echo
echo "== Template section presence check =="
gh pr view 1520 --repo OWASP/Nettacker --json body --jq '.body' | \
python - <<'PY'
import sys
body = sys.stdin.read()
required = ["Proposed change", "Type of change", "Checklist"]
missing = [s for s in required if s.lower() not in body.lower()]
if missing:
    print("Missing sections:", ", ".join(missing))
else:
    print("All required section headers detected.")
PY

echo
echo "== Commit signature verification =="
gh api repos/OWASP/Nettacker/pulls/1520/commits --paginate | \
jq -r '.[] | [.sha[0:12], .commit.verification.verified, (.commit.verification.reason // "unknown")] | `@tsv`'

Repository: OWASP/Nettacker

Length of output: 4589

🏁 Script executed:

#!/bin/bash
# Retry commit signature verification for PR 1520 with timeout handling
timeout 30 gh api repos/OWASP/Nettacker/pulls/1520/commits --jq '.[] | {sha: .sha[0:12], author: .commit.author.name, verified: .commit.verification.verified, reason: .commit.verification.reason}'

Repository: OWASP/Nettacker

Length of output: 106

🏁 Script executed:

#!/bin/bash
# Commit signature verification for PR 1520
gh api repos/OWASP/Nettacker/pulls/1520/commits --jq '.[] | {sha: .sha[0:12], author: .commit.author.name, verified: .commit.verification.verified, reason: .commit.verification.reason}' | head -50

Repository: OWASP/Nettacker

Length of output: 146

PR template non-compliant and commit unsigned — blocks merge.

This PR is missing all three required template sections ("Proposed change", "Type of change", "Checklist"). The PR body uses custom headers instead of .github/PULL_REQUEST_TEMPLATE.md format.

Additionally, the commit (4b390d6 by Hashem Aldhaheri) is unsigned. All commits in this repository must be GPG signed. @aenawi, please:

  1. Rewrite the PR description to match the three required template sections.
  2. Sign the commit and force-push: 
    git commit --amend -S --no-edit
git push --force-with-lease
    Or use git rebase --exec 'git commit --amend --no-edit -S' ... if multiple commits need signing.
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@Dockerfile` around lines 50 - 52, The PR is missing the required template
sections and the commit 4b390d6f32ad is unsigned; update the PR description to
include the three required headers "Proposed change", "Type of change", and
"Checklist" matching .github/PULL_REQUEST_TEMPLATE.md exactly, then locally sign
the offending commit (or all commits if needed) and force-push: run git commit
--amend -S --no-edit (or git rebase --exec 'git commit --amend --no-edit -S' ...
for multiple commits) and git push --force-with-lease so the commit(s) are
GPG-signed and the PR body complies with the template.

### We now have Nettacker installed in the virtualenv with 'nettacker' command which is the new entrypoint
ENV docker_env=true
ENTRYPOINT [ "nettacker" ]
Expand Down
Loading