Skip to content

fix: add guards for debian family specific calls#153

Open
cenk1cenk2 wants to merge 1 commit into
Oefenweb:masterfrom
cenk1cenk2:patch-1
Open

fix: add guards for debian family specific calls#153
cenk1cenk2 wants to merge 1 commit into
Oefenweb:masterfrom
cenk1cenk2:patch-1

Conversation

@cenk1cenk2

Copy link
Copy Markdown

Hey oefenweb,

Thank you for this package, I have been using it for years.

I just wanted to add a small guard around to make this purely a configuration role without making it per operating system or running this with tags.

  • Adds a guard around the debian OS family cases.

@tersmitten

Copy link
Copy Markdown
Member

But this role only supports Debian-like systems 🤔

@cenk1cenk2

Copy link
Copy Markdown
Author

hey @tersmitten,

thank you for the reply.

yes that is essentially still true, but with this tiny addition it will give the flexibility to also support others since nothing else here seemed os specific.

or am i mistaken?

@tersmitten

Copy link
Copy Markdown
Member

No, you're right. But we're not planning to support other distros and add complexity to do so.

@cenk1cenk2

Copy link
Copy Markdown
Author

Okay, I completely understand the point.

Thank you very much for the review and your time.

I suppose this would not be a worthy addition then even though it is a low effort one to not do package installs on not supported systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants