fix: add guards for debian family specific calls#153
Open
cenk1cenk2 wants to merge 1 commit into
Open
Conversation
fix: . fix: .
Member
|
But this role only supports Debian-like systems 🤔 |
Author
|
hey @tersmitten, thank you for the reply. yes that is essentially still true, but with this tiny addition it will give the flexibility to also support others since nothing else here seemed os specific. or am i mistaken? |
Member
|
No, you're right. But we're not planning to support other distros and add complexity to do so. |
Author
|
Okay, I completely understand the point. Thank you very much for the review and your time. I suppose this would not be a worthy addition then even though it is a low effort one to not do package installs on not supported systems. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey oefenweb,
Thank you for this package, I have been using it for years.
I just wanted to add a small guard around to make this purely a configuration role without making it per operating system or running this with tags.
debianOS family cases.