fix: ensure correct network before any transaction#2498
Open
chrstph-dvx wants to merge 8 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
spsjvc
reviewed
Jun 4, 2025
chrstph-dvx
force-pushed
the
fix-check-for-network-before-tx
branch
from
ce42c8e to
ee32f1b
Compare
douglance
reviewed
Jun 6, 2025
douglance
left a comment
douglance
left a comment
Contributor
There was a problem hiding this comment.
there are three different ways to get source chain id. seems like that should be in the transfer starter constructor. but not worth addressing in this PR. just thought it was interesting.
chrstph-dvx
force-pushed
the
fix-check-for-network-before-tx
branch
from
7b279ff to
c7a2435
Compare
chrstph-dvx
force-pushed
the
fix-check-for-network-before-tx
branch
from
c7a2435 to
ace2423
Compare
chrstph-dvx
force-pushed
the
fix-check-for-network-before-tx
branch
2 times, most recently
from
cd05671 to
d69e026
Compare
chrstph-dvx
force-pushed
the
fix-check-for-network-before-tx
branch
from
d69e026 to
df4759c
Compare
chrstph-dvx
force-pushed
the
fix-check-for-network-before-tx
branch
from
df4759c to
7cfa4d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Steps to test