Skip to content

Ramsundar - Fixed Functionality issues on the Inventory types page(Frontend)#5074

Closed
Ram-blip wants to merge 2 commits into
developmentfrom
Frontend-inventory-types-functional-issue-fixes
Closed

Ramsundar - Fixed Functionality issues on the Inventory types page(Frontend)#5074
Ram-blip wants to merge 2 commits into
developmentfrom
Frontend-inventory-types-functional-issue-fixes

Conversation

@Ram-blip
Copy link
Copy Markdown
Contributor

@Ram-blip Ram-blip commented Mar 27, 2026

Description

Screenshot 2026-03-27 at 4 42 38 PM

Related PRS (if any):

This frontend PR is related to the #2131 backend PR.

Main changes explained:

  • Separated the reusable create flow from the tool create flow.
  • Migrated “unit of measurement” storage from the old JSON-file approach to a MongoDB model, The backend now reads, adds, and deletes units through the database.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Go to "http://localhost:5173/bmdashboard/inventorytypes"
  6. First check: Go add item in reusables, items will get added in reusables, there is no need to refresh, it updates immediately. Do the same thing for tools.
  7. Second check: Go to unit of measurement, add any measurement, it will get added. Also, the delete will also work. Error page won't come.

Screenshots or videos of changes:

Video Proof After changes:
https://www.loom.com/share/c1f26c4fe96241c2b5c6cb107c69b955

Note:

Include the information the reviewers need to know.

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 27, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit ef80b23
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69fedefa1a02c500082b503d
😎 Deploy Preview https://deploy-preview-5074--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown

@Vishnu10-hub Vishnu10-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

Tested the Frontend-inventory-types-functional-issue-fixes branch locally. Able to add tools successfully, but encountered errors while updating types

Image Image Image

. Additionally, deletion of Units of Measurement is not working as expected.

@Ram-blip
Copy link
Copy Markdown
Contributor Author

Ram-blip commented Apr 9, 2026

Hi,

Tested the Frontend-inventory-types-functional-issue-fixes branch locally. Able to add tools successfully, but encountered errors while updating types

Image Image Image
. Additionally, deletion of Units of Measurement is not working as expected.

Hi Vishnu,

Are you telling that you are encountering errors while trying to add an item in reusable?

@Ram-blip Ram-blip requested a review from Vishnu10-hub April 11, 2026 08:18
@Ram-blip
Copy link
Copy Markdown
Contributor Author

Hi,

Tested the Frontend-inventory-types-functional-issue-fixes branch locally. Able to add tools successfully, but encountered errors while updating types

Image Image Image
. Additionally, deletion of Units of Measurement is not working as expected.

Hey Vishnu,

Can you check again? I have solved merge conflicts and i checked again, Everything is working as expected.

Thanks!

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label May 5, 2026
Copy link
Copy Markdown

@HemanthNidamanuru HemanthNidamanuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ramsundar,

The following issues are resolved:

  1. Inventory types (tools and reusables) list updates correctly after addition.
  2. Items are now added to the correct category.
  3. "Unit of measurement" add button no longer throws a server error.

However, the following UI issues were noticed during testing:

  1. Form validation is missing for some fields.
  2. Calendar is not aligned in dark mode.
  3. Country code is not aligned in dark mode.
  4. Able to select future dates for Purchase/Rent.

Could you let me know if these fall under the scope of this PR?

Image Image Image

@Ram-blip
Copy link
Copy Markdown
Contributor Author

Ram-blip commented May 6, 2026

Hi Ramsundar,

The following issues are resolved:

  1. Inventory types (tools and reusables) list updates correctly after addition.
  2. Items are now added to the correct category.
  3. "Unit of measurement" add button no longer throws a server error.

However, the following UI issues were noticed during testing:

  1. Form validation is missing for some fields.
  2. Calendar is not aligned in dark mode.
  3. Country code is not aligned in dark mode.
  4. Able to select future dates for Purchase/Rent.

Could you let me know if these fall under the scope of this PR?

Image Image Image

Hi Hemanth,

I don’t think these UI issues fall under the scope of this PR. My goal for this PR was to fix the inventory types functionality, mainly making sure tools and reusables update correctly after addition, items are added to the correct category, and the list refreshes properly.

For the unit of measurement issue, it was previously handled through a JSON file, which was causing the server errors. I migrated it to a new MongoDB model, so the add/delete flow should now work correctly.

Thank you for your detailed review.

@Ram-blip Ram-blip requested a review from HemanthNidamanuru May 6, 2026 14:03
@Ram-blip Ram-blip force-pushed the Frontend-inventory-types-functional-issue-fixes branch from ed7f2bc to ef80b23 Compare May 9, 2026 07:15
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 9, 2026

@one-community
Copy link
Copy Markdown
Member

Hi Ramsundar,
The following issues are resolved:

  1. Inventory types (tools and reusables) list updates correctly after addition.
  2. Items are now added to the correct category.
  3. "Unit of measurement" add button no longer throws a server error.

However, the following UI issues were noticed during testing:

  1. Form validation is missing for some fields.
  2. Calendar is not aligned in dark mode.
  3. Country code is not aligned in dark mode.
  4. Able to select future dates for Purchase/Rent.

Could you let me know if these fall under the scope of this PR?
Image Image Image

Hi Hemanth,

I don’t think these UI issues fall under the scope of this PR. My goal for this PR was to fix the inventory types functionality, mainly making sure tools and reusables update correctly after addition, items are added to the correct category, and the list refreshes properly.

For the unit of measurement issue, it was previously handled through a JSON file, which was causing the server errors. I migrated it to a new MongoDB model, so the add/delete flow should now work correctly.

Thank you for your detailed review.

Easy fixes like this should be handled in this PR so we don’t have to create new action items, please fix these

@one-community
Copy link
Copy Markdown
Member

Dev says no longer needed, problems fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants