Ramsundar - Fixed Functionality issues on the Inventory types page(Frontend)#5074
Ramsundar - Fixed Functionality issues on the Inventory types page(Frontend)#5074Ram-blip wants to merge 2 commits into
Conversation
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Ramsundar,
The following issues are resolved:
- Inventory types (tools and reusables) list updates correctly after addition.
- Items are now added to the correct category.
- "Unit of measurement" add button no longer throws a server error.
However, the following UI issues were noticed during testing:
- Form validation is missing for some fields.
- Calendar is not aligned in dark mode.
- Country code is not aligned in dark mode.
- Able to select future dates for Purchase/Rent.
Could you let me know if these fall under the scope of this PR?
Hi Hemanth, I don’t think these UI issues fall under the scope of this PR. My goal for this PR was to fix the inventory types functionality, mainly making sure tools and reusables update correctly after addition, items are added to the correct category, and the list refreshes properly. For the unit of measurement issue, it was previously handled through a JSON file, which was causing the server errors. I migrated it to a new MongoDB model, so the add/delete flow should now work correctly. Thank you for your detailed review. |
ed7f2bc to
ef80b23
Compare
|
|
Dev says no longer needed, problems fixed |















Description
Related PRS (if any):
This frontend PR is related to the #2131 backend PR.
Main changes explained:
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Video Proof After changes:
https://www.loom.com/share/c1f26c4fe96241c2b5c6cb107c69b955
Note:
Include the information the reviewers need to know.