Sayali: resolve duplicate badge assignment and fix checkbox display for existing badges in dark mode#5223
Open
sayali-2308 wants to merge 1 commit into
Open
Sayali: resolve duplicate badge assignment and fix checkbox display for existing badges in dark mode#5223sayali-2308 wants to merge 1 commit into
sayali-2308 wants to merge 1 commit into
Conversation
…existing badges in dark mode
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
HemanthNidamanuru
requested changes
May 4, 2026
Contributor
Author
|
Hi @HemanthNidamanuru , I tested locally and the badge assignment is working correctly on my end with no team codes errors. The 'retrieve team codes' toast is unrelated to this PR it comes from fetchTeamCodeAllUsers calling the WEEKLY_SUMMARIES_TEAM_CODES backend endpoint. Please ensure your backend is running on port 4500 with npm run build then npm start and try again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Fixes #3237 (Priority Medium)
Main changes explained:
returnUpdatedBadgesCollectionSingleUserinbadgeManagement.jsto use immutable approach preventing duplicate entries on all existing badges when a new badge is assignede.targethyperlink inAssignTableRow.jsxpropExistBadgesprop name mismatch inUserProfile/AssignBadgePopup.jsxisSelectedlogic so existing badges show as checked when modal opensBadgeReport.jsxHow to test:
npm installandnpm run start:localScreenshots:
Note:
This PR finishes the work started in PR #3237 from scratch with a cleaner fix.