Sayali : fix reviewer feedback issues - load reviewers from config, fix auth token, fix React Fragment key#5235
Open
sayali-2308 wants to merge 4 commits into
Open
Sayali : fix reviewer feedback issues - load reviewers from config, fix auth token, fix React Fragment key#5235sayali-2308 wants to merge 4 commits into
sayali-2308 wants to merge 4 commits into
Conversation
…uth token, fix React Fragment key
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
HemanthNidamanuru
requested changes
May 8, 2026
HemanthNidamanuru
left a comment
HemanthNidamanuru
left a comment
There was a problem hiding this comment.
Hi Sayali,
Thank you for working on this PR.
Issue found during testing:
- "Error saving grades. Please try again." appears on the grading screen. Please fix the save functionality.
one-community
changed the title
sayali-2308
changed the title
Contributor
Author
|
Hi @HemanthNidamanuru thank you for testing! I've fixed the 'Error saving grades' issue — it was caused by static test teams (like 91NePRT) not having a teamCode, which caused the save API call to fail. I've added a guard to handle this case and also resolved the merge conflict with development. Please re-test on the updated branch. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes reviewer feedback issues for Task #12 (Priority Urgent)
Related PRs:
This is a follow-up fix to frontend PR #5164 (already merged).
Backend PR: #3826 (already merged).
Main changes explained:
index.jsxto fetch reviewer names from PR grading config so reviewers appear immediately for dynamic teams without needing a refreshPRGradingScreen.jsxby replacing<>with<React.Fragment key={reviewer.id}>weeklyGradingActions.jsto remove unused token parameterPRGradingTest.jsxto pass team name when navigating to grading screenHow to test:
Sayali_Weekly_PR_Grading_Fixesnpm installandnpm run start:localhttp://localhost:5173/pr-grading-testScreenshots or videos of changes:
Note:
Follow-up fix to PR #5164. Addresses reviewer feedback about grades not saving, team name not showing, and PR numbers disappearing after reload.