Skip to content

[projmgr] Set target-set specific tmpdir as default#2508

Merged
brondani merged 2 commits into
mainfrom
projmgr-default-tmpdir
Jun 29, 2026
Merged

[projmgr] Set target-set specific tmpdir as default#2508
brondani merged 2 commits into
mainfrom
projmgr-default-tmpdir

Conversation

@brondani

@brondani brondani commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

Set a target-set specific default for build index tmpdir when an active target is selected.
This aligns default tmpdir behavior with active target context and avoids collisions across target sets.

  • Updated tmpdir defaulting logic in ProjMgr worker:
    • If active target type is present and tmpdir is not explicitly set, use target-specific default path.
    • If tmpdir is explicitly set, still expand target access sequences as before.
    • Final tmpdir remains rooted at solution/output base path.
  • Updated reference outputs for scenarios now expected to generate target-specific tmpdir.
  • Added a new unit test covering default tmpdir behavior with an active target selection.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates ProjMgr’s tmpdir defaulting so that when an active target is selected, the build index tmpdir defaults to a target-type/target-set–specific subdirectory to avoid collisions across target sets.

Changes:

  • Updated ProjMgrWorker::UpdateTmpDir() to default tmpdir to tmp/<TargetType>/<TargetSet> when an active target is present, while still expanding target access sequences for explicitly configured tmpdir values.
  • Updated expected/reference .cbuild-idx.yml outputs to reflect the new default tmpdir shape (e.g., tmp/CM0/default).
  • Added a unit test and a new .csolution.yml input covering the default tmpdir behavior with an active target selection.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tools/projmgr/src/ProjMgrWorker.cpp Implements the new target-set–specific tmpdir defaulting logic when an active target is present.
tools/projmgr/test/src/ProjMgrUnitTests.cpp Adds a unit test validating the new default tmpdir behavior under --active.
tools/projmgr/test/data/TestSolution/tmpdir-default-active.csolution.yml Adds a minimal solution input for the new unit test scenario.
tools/projmgr/test/data/WestSupport/ref/solution.cbuild-idx.yml Updates reference output to the new tmpdir default for CM0/default.
tools/projmgr/test/data/ImageOnly/ref/image-only.cbuild-idx.yml Updates reference output to the new tmpdir default for CM0/default in image-only mode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/projmgr/src/ProjMgrWorker.cpp
@github-actions

Copy link
Copy Markdown

Test Results

    3 files     21 suites   18m 19s ⏱️
  474 tests   474 ✅ 0 💤 0 ❌
1 422 runs  1 422 ✅ 0 💤 0 ❌

Results for commit 66ecf02.

@brondani brondani marked this pull request as ready for review June 29, 2026 10:46
@brondani brondani requested a review from edriouk June 29, 2026 10:46
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.29%. Comparing base (5c2482f) to head (66ecf02).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2508   +/-   ##
=======================================
  Coverage   65.29%   65.29%           
=======================================
  Files         147      147           
  Lines       26702    26702           
  Branches    16184    16184           
=======================================
+ Hits        17434    17435    +1     
  Misses       7073     7073           
+ Partials     2195     2194    -1     
Flag Coverage Δ
projmgr-cov 88.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 87.50% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edriouk edriouk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani brondani merged commit 33fac87 into main Jun 29, 2026
34 checks passed
@brondani brondani deleted the projmgr-default-tmpdir branch June 29, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants