[projmgr] Set target-set specific tmpdir as default#2508
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates ProjMgr’s tmpdir defaulting so that when an active target is selected, the build index tmpdir defaults to a target-type/target-set–specific subdirectory to avoid collisions across target sets.
Changes:
- Updated
ProjMgrWorker::UpdateTmpDir()to default tmpdir totmp/<TargetType>/<TargetSet>when an active target is present, while still expanding target access sequences for explicitly configured tmpdir values. - Updated expected/reference
.cbuild-idx.ymloutputs to reflect the new default tmpdir shape (e.g.,tmp/CM0/default). - Added a unit test and a new
.csolution.ymlinput covering the default tmpdir behavior with an active target selection.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/projmgr/src/ProjMgrWorker.cpp | Implements the new target-set–specific tmpdir defaulting logic when an active target is present. |
| tools/projmgr/test/src/ProjMgrUnitTests.cpp | Adds a unit test validating the new default tmpdir behavior under --active. |
| tools/projmgr/test/data/TestSolution/tmpdir-default-active.csolution.yml | Adds a minimal solution input for the new unit test scenario. |
| tools/projmgr/test/data/WestSupport/ref/solution.cbuild-idx.yml | Updates reference output to the new tmpdir default for CM0/default. |
| tools/projmgr/test/data/ImageOnly/ref/image-only.cbuild-idx.yml | Updates reference output to the new tmpdir default for CM0/default in image-only mode. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 3 files 21 suites 18m 19s ⏱️ Results for commit 66ecf02. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2508 +/- ##
=======================================
Coverage 65.29% 65.29%
=======================================
Files 147 147
Lines 26702 26702
Branches 16184 16184
=======================================
+ Hits 17434 17435 +1
Misses 7073 7073
+ Partials 2195 2194 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes
Changes
Set a target-set specific default for build index tmpdir when an active target is selected.
This aligns default tmpdir behavior with active target context and avoids collisions across target sets.
Checklist