Skip to content

Fix release job's download build artifacts step - #32

Merged
JonatanAntoni merged 1 commit into
mainfrom
fix-release
Aug 6, 2026
Merged

Fix release job's download build artifacts step#32
JonatanAntoni merged 1 commit into
mainfrom
fix-release

Conversation

@JonatanAntoni

Copy link
Copy Markdown
Member

No description provided.

@JonatanAntoni
JonatanAntoni requested a lite review from Copilot August 6, 2026 12:20
@qltysh

qltysh Bot commented Aug 6, 2026

Copy link
Copy Markdown

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@qltysh

qltysh Bot commented Aug 6, 2026

Copy link
Copy Markdown

❌ 1 blocking issue (1 total)

Tool Category Rule Count
zizmor Vulnerability code injection via template expansion 1

Comment thread .github/workflows/ci.yml
GH_TOKEN: ${{ github.token }}
RELEASE_TAG: ${{ github.event.release.tag_name }}
run: gh release upload "$RELEASE_TAG" release-assets/* --clobber
run: gh release upload "${{ github.event.release.tag_name }}" release-assets/* --repo "${{ github.repository }}" --clobber

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code injection via template expansion [zizmor:zizmor/template-injection]

@JonatanAntoni
JonatanAntoni merged commit bdfbf64 into main Aug 6, 2026
21 of 23 checks passed
@JonatanAntoni
JonatanAntoni deleted the fix-release branch August 6, 2026 12:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions release workflow to correctly download build artifacts produced by the build matrix and reliably upload them to the GitHub release.

Changes:

  • Pin actions/download-artifact to a specific commit (v8.0.1) for the release job.
  • Add skip-decompress: true when downloading artifacts into release-assets/.
  • Update the gh release upload invocation to use the release tag expression directly and explicitly set --repo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants