Add AI code review customization files#1460
Draft
makubacki wants to merge 2 commits intoOpenDevicePartnership:mainfrom
Draft
Add AI code review customization files#1460makubacki wants to merge 2 commits intoOpenDevicePartnership:mainfrom
makubacki wants to merge 2 commits intoOpenDevicePartnership:mainfrom
Conversation
Adds project-level AI customization files to support AI-assisted code review. These files encode Patina's domain-specific conventions so that AI reviewers can flag violations locally, prior to human review. The files are layered: 1. Always-on instructions (.github/copilot-instructions.md): Covers global conventions across the codebase. 2. File-based instructions (.github/instructions/): Currently, provides component-specific instructions in components.instructions.md(applyTo: components/**) to supplement the global instructions. These load only when editing matching files to minimize token cost. 3. Review prompt file (.github/prompts/review.prompt.md): A reusable /review slash command that defines a structured review checklist. This is to provide a convenient way to reliably perform the same set of review steps. Delegates convention details to the always-on instructions to avoid duplication. 4. Reviewer agent (.github/agents/reviewer.agent.md): A read-only review persona restricted to `search` and `read` tool sets (no edit or execute tools). Includes a handoff to the default agent for implementing fixes after review. References: - VS Code Customization Overview: https://code.visualstudio.com/docs/copilot/concepts/customization - Custom Instructions: https://code.visualstudio.com/docs/copilot/customization/custom-instructions - Prompt Files: https://code.visualstudio.com/docs/copilot/customization/prompt-files - Custom Agents: https://code.visualstudio.com/docs/copilot/customization/custom-agents Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
Contributor
✅ QEMU Validation PassedAll QEMU validation jobs completed successfully.
Workflow run: https://github.com/OpenDevicePartnership/patina/actions/runs/24208819731 Boot Time to EFI Shell
Dependencies
This comment was automatically generated by the Patina QEMU PR Validation Post workflow. |
github-actions
bot
added
the
impact:non-functional
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Javagedes
reviewed
Apr 9, 2026
Javagedes
reviewed
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #1453
Adds project-level AI customization files to support AI-assisted code review.
These files encode Patina's domain-specific conventions so that AI reviewers can flag violations locally, prior to human review.
The files are layered:
Always-on instructions (.github/copilot-instructions.md): Covers global conventions across the codebase.
File-based instructions (.github/instructions/): Currently, provides component-specific instructions in components.instructions.md(applyTo: components/**) to supplement the global instructions. These load only when editing matching files to minimize token cost.
Review prompt file (.github/prompts/review.prompt.md): A reusable /review slash command that defines a structured review checklist. This is to provide a convenient way to reliably perform the same set of review steps. Delegates convention details to the always-on instructions to avoid duplication.
Reviewer agent (.github/agents/reviewer.agent.md): A read-only review persona restricted to
searchandreadtool sets (no edit or execute tools). Includes a handoff to the default agent for implementing fixes after review.References:
VS Code Customization Overview: https://code.visualstudio.com/docs/copilot/concepts/customization
Custom Instructions: https://code.visualstudio.com/docs/copilot/customization/custom-instructions
Prompt Files: https://code.visualstudio.com/docs/copilot/customization/prompt-files
Custom Agents: https://code.visualstudio.com/docs/copilot/customization/custom-agents
Impacts functionality?
Impacts security?
Breaking change?
Includes tests?
Includes documentation?
How This Was Tested
Integration Instructions
This PR is in draft as it serves as a starting open to changes from others before publishing for broader review.