Skip to content

Add test for example and template to be valid frictionless datapackage#305

Open
Ludee wants to merge 31 commits intodevelopfrom
feature-290-frictionless-test
Open

Add test for example and template to be valid frictionless datapackage#305
Ludee wants to merge 31 commits intodevelopfrom
feature-290-frictionless-test

Conversation

@Ludee
Copy link
Copy Markdown
Member

@Ludee Ludee commented Apr 9, 2026

Summary of the discussion

Use frictionless-py validate function in tests.

Type of change (CHANGELOG.md)

Added

  • Tests for example and template to be valid frictionless datapackage (#305)

Workflow checklist

Automation

Closes #290 / Part of #296

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee requested a review from jh-RLI April 9, 2026 07:59
@Ludee Ludee self-assigned this Apr 9, 2026
@Ludee Ludee added priority: critical 🔥 Critical priority part: backend 🧱 Backend component type: feature 🛠 New feature or request status: completed ✔️ Task has been completed labels Apr 9, 2026
@Ludee Ludee added status: blocked 🛑 Blocked or impeded progress and removed status: completed ✔️ Task has been completed labels Apr 9, 2026
@Ludee Ludee marked this pull request as draft April 9, 2026 20:07
@jh-RLI jh-RLI mentioned this pull request Apr 10, 2026
6 tasks
Copy link
Copy Markdown
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest tp focus on this PR before continuing work on the other "oem content" related PR´s

Most tests are failing as you used "type": "text", instead of "type": "string",

Please also put the option of "null" if a property is not required:

          "type": [
            "string",
            "null"
          ],

@Ludee Ludee marked this pull request as ready for review April 27, 2026 12:57
@Ludee Ludee requested a review from jh-RLI April 27, 2026 19:02
"name": "id",
"description": "Unique identifier",
"type": "serial",
"type": "integer",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integer is okay, most times there is something wit a range of bits. There might be infinit rows in the dataset.

I think this is not relevant for this example so just a comment.

with open(BASE_PATH / "example.json", encoding="utf-8") as f:
descriptor = json.load(f)

OEMETADATA_V21_EXAMPLE = Package(descriptor, basepath=str(BASE_PATH))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to test this as it might change how this is handled e.g. in the OEP.

There is a diff. between json.load and .loads. we should keep ".loads" and also the "rb" mode.

But as this is scoped to this version it iwll not break things ... at least for now ;)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you handle this here already

Package(descriptor, basepath=str(BASE_PATH))

@jh-RLI
Copy link
Copy Markdown
Contributor

jh-RLI commented Apr 29, 2026

In general we can just merge this. But we need to check the changes to the module import functionality for example and template in all cases where we integrated oemetadata and or omi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part: backend 🧱 Backend component priority: critical 🔥 Critical priority status: blocked 🛑 Blocked or impeded progress type: feature 🛠 New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check if our Dataset is valid agaist frictionless data "Package"

2 participants