Skip to content

[WIP] Add analysis for symmetry corrected RMSD#92

Draft
hannahbaumann wants to merge 6 commits into
rmsd_refactor_analysisbasefrom
spyrmsd
Draft

[WIP] Add analysis for symmetry corrected RMSD#92
hannahbaumann wants to merge 6 commits into
rmsd_refactor_analysisbasefrom
spyrmsd

Conversation

@hannahbaumann
Copy link
Copy Markdown
Contributor

No description provided.

@hannahbaumann hannahbaumann linked an issue Feb 27, 2026 that may be closed by this pull request
@hannahbaumann hannahbaumann marked this pull request as draft February 27, 2026 12:13
@hannahbaumann hannahbaumann changed the title Add analysis for symmetry corrected RMSD [WIP] Add analysis for symmetry corrected RMSD Feb 27, 2026
@hannahbaumann hannahbaumann changed the base branch from main to rmsd_refactor_analysisbase February 27, 2026 12:13
@hannahbaumann hannahbaumann self-assigned this Mar 2, 2026
@hannahbaumann
Copy link
Copy Markdown
Contributor Author

The difference between the old ligand RMSD and the symmetry corrected ligand RMSD on the skipped dataset is quite big and the symmetry corrected ligand RMSD is greater (esp. at frame 5) which seemed weird.
The last test however shows that this is not due to symmetry correction (or the use of the state ligand and not the hybrid ligand), but since we are not doing mass weighting in the symmetry corrected RMSD which has a large effect here due to a Br atom.

Questions:

  • Would we want to implement mass weighting for the symmetry corrected RMSD? Do other packages report mass weighted RMSD or not?
  • Which "ligand" RMSD do we want to report? So far we had reported the RMSD of the hybrid topology, which, esp. when the number of dummy atoms is large, can lead to a large RMSD, even when the RMSD of the physical atoms might be small.
    • Would we want to report two ligand RMSD, for ligand A and ligand B?
    • Would we want to use physical atoms in the pure end states and hybrid topology for the intermediate lambda windows?

Do you have any thoughts @IAlibay or @jthorton ?

assert corrected.results.rmsd[1] == pytest.approx(0.0, abs=1e-5)


def test_ligand_rmsd_mass_weighting_effect(simulation_skipped_nc, hybrid_system_skipped_pdb):
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is just here for trouble shooting of the differences between the old RMSD and symmetry corrected. Will remove once things are sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using symmetry corrected RMSD for ligands

1 participant