Skip to content

fix(db): honor SQLite pool settings - #382

Open
onatozmenn wants to merge 2 commits into
OpenHands:mainfrom
onatozmenn:fix/sqlite-pool-settings
Open

onatozmenn wants to merge 2 commits into
OpenHands:mainfrom
onatozmenn:fix/sqlite-pool-settings

Conversation

@onatozmenn

@onatozmenn onatozmenn commented Aug 24, 2026

Copy link
Copy Markdown

HUMAN:

I tested both SQLite memory URL formats locally and ran the test suite to make sure nothing broke.

AGENT:

File-backed SQLite was silently using SQLAlchemy's 5+10 pool defaults, so changing the service's pool settings had no effect. This passes the configured size, overflow, and timeout through while leaving in-memory databases on StaticPool.

I covered the regular :memory: URL and both SQLite URI memory forms so the new kwargs don't break test or embedded setups.

Tests: uv run pytest tests/test_db.py -q (31 passed), Ruff format/check, and Pyright. The wider non-integration suite reached 1,439 passes; its only Postgres testcontainer setup timeout passed on an isolated rerun.

Fixes #366

Signed-off-by: onatozmenn <onatozmen44@gmail.com>
@github-actions github-actions Bot added the type: fix A bug fix label Aug 24, 2026
@all-hands-bot

Copy link
Copy Markdown
Contributor

👋 This PR needs a couple of things fixed before OpenHands can review it:

  • the PR description's HUMAN: section needs at least 20 characters describing what you tested, not just the template placeholder

Push an update once this is addressed and this check re-runs automatically.

This is an automated check - no AI was used to generate this comment.

…tings

Signed-off-by: onatozmenn <onatozmen44@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQLite engine ignores db_pool_size/db_max_overflow/db_pool_timeout, pinning the pool at QueuePool 5+10

2 participants