fix(db): honor SQLite pool settings - #382
Open
onatozmenn wants to merge 2 commits into
Open
onatozmenn wants to merge 2 commits into
onatozmenn wants to merge 2 commits into
Conversation
Signed-off-by: onatozmenn <onatozmen44@gmail.com>
Contributor
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
…tings Signed-off-by: onatozmenn <onatozmen44@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
I tested both SQLite memory URL formats locally and ran the test suite to make sure nothing broke.
AGENT:
File-backed SQLite was silently using SQLAlchemy's 5+10 pool defaults, so changing the service's pool settings had no effect. This passes the configured size, overflow, and timeout through while leaving in-memory databases on
StaticPool.I covered the regular
:memory:URL and both SQLite URI memory forms so the new kwargs don't break test or embedded setups.Tests:
uv run pytest tests/test_db.py -q(31 passed), Ruff format/check, and Pyright. The wider non-integration suite reached 1,439 passes; its only Postgres testcontainer setup timeout passed on an isolated rerun.Fixes #366