fix(ci): pull MinIO test image from Quay - #447
Conversation
|
@VascoSch92 @enyst, this focused CI fix unblocks the unit-test jobs on #437 and #446. Both feature runs passed 1,703 tests and then hit the same 17 setup errors because Docker Hub now returns 404 for the pinned |
|
🚦 CI is currently failing on this PR's latest commit. Please fix the failing checks before OpenHands reviews it - this is re-checked automatically once you push a new commit. (A maintainer can also request This is an automated check - no AI was used to generate this comment. |
enyst
left a comment
There was a problem hiding this comment.
Verified with Astra.
Thank you!
|
🤖 OpenHands is reviewing this PR. Head commit: This comment was posted by an AI agent (OpenHands). |
all-hands-bot
left a comment
There was a problem hiding this comment.
This review was created by an AI agent (OpenHands) on behalf of the repository maintainers.
Verdict: ✅ Worth merging
Taste Rating: 🟢 Good taste — minimal, targeted fix.
This PR overrides Testcontainers' default Docker Hub image (minio/minio:RELEASE.2022-12-02T19-19-22Z) with the identical release tag hosted on Quay (quay.io/minio/minio:RELEASE.2022-12-02T19-19-22Z). Docker Hub now returns 404 for that tag, which broke the MinIO-backed S3 integration tests in recent CI runs.
Verified
- Docker Hub 404 confirmed:
HEAD https://hub.docker.com/v2/repositories/minio/minio/tags/RELEASE.2022-12-02T19-19-22Z→ 404. - Quay image exists:
HEAD https://quay.io/v2/minio/minio/manifests/RELEASE.2022-12-02T19-19-22Z→ 200. - API compatibility:
MinioContainer.__init__accepts animage: strparameter and passes it to the parentDockerContainer. The Quay image reference is a fully qualified registry path, which Docker handles natively — no behavioral change. - Same release tag: The tag string is identical, only the registry prefix changes. The MinIO binary inside is the same release.
- No other references:
minio/minioappears only in this one test file across the repo, so the fix is complete. - CI evidence: PR #449 (which includes this fix) shows 1,734 passed / 7 skipped in the unit-test job, confirming the Quay image pulls and tests pass.
No material issues
The change is 3 lines: a module-level constant and passing it to the existing constructor. No security, correctness, or design concerns.
[RISK ASSESSMENT]
- Overall PR: 🟢 LOW
- Test-only change; no production code or runtime behavior affected. The image tag is unchanged — only the registry host differs. Quay is an established, trusted registry (Red Hat operated). No supply-chain concern since the tag is a pinned release already in use.
KEY INSIGHT: The fix correctly addresses a transient upstream registry outage by switching to an equally authoritative mirror with the same pinned tag, with no behavioral change to the test suite.
|
This comment was posted by an AI agent (OpenHands). |
Why
The unit-test workflow can no longer start the MinIO-backed S3 integration tests because Docker Hub now returns 404 for
minio/minio, including the tag used by Testcontainers. This produced 17 setup errors in otherwise passing runs on PR 437 and PR 446.Summary
Override Testcontainers' legacy Docker Hub default with the same official MinIO release hosted on Quay. The release tag and test behavior stay unchanged; only the image registry changes.
Issue Number
N/A — shared CI dependency outage.
How to Test
minio/minio:RELEASE.2022-12-02T19-19-22Z.MinioContainerreceives the explicit Quay image reference.git diff --checksuccessfully.HUMAN: I reviewed the failed workflow logs from both affected PRs and verified the replacement image tag.
Recorded evidence
Before: PR #437 unit-test job has 17 MinIO setup errors because Docker Hub returns image 404. After: composed PR #449 unit-test job pulls the same release from Quay and reports 1,734 passed, 7 skipped. The passing job belongs to #449, which includes this unchanged image repair; #447 itself has no current unit-test job. This is integration evidence for the image repair, not a changed Canvas interface.