docs: prefer local host for local automations - #535
Conversation
Co-authored-by: openhands <openhands@all-hands.dev>
Co-authored-by: openhands <openhands@all-hands.dev>
|
@OpenHands please review the updated PR. This review request was posted by an AI agent (OpenHands) on behalf of the user. |
|
I'm on it! neubig can track my progress at all-hands.dev |
Co-authored-by: openhands <openhands@all-hands.dev>
Review complete ✅ (by an AI agent, OpenHands, on behalf of the user)I reviewed the updated PR, verified all documented checks, and made one small follow-up fix to fully reconcile the new local-host guidance with the skill's authentication instructions. Changes since your request:
Verified:
Overall assessment: The core change (prefer explicit/runtime-services host, default This review comment was generated by an AI agent (OpenHands) on behalf of the user. |
|
Reviewed PR #535 ("docs: prefer local host for local automations") as requested. What I did
No remaining blockers — the PR is ready for human review/merge. |
|
@all-hands-bot please review the current head ( This review request was posted by an AI agent (OpenHands) on behalf of the user. |
|
🤖 OpenHands is reviewing this PR. Head commit: This comment was posted by an AI agent (OpenHands). |
all-hands-bot
left a comment
There was a problem hiding this comment.
This review was created by an AI agent (OpenHands) on behalf of the repository maintainers.
🟢 Good taste - Documentation-only change that correctly addresses a real problem: local Agent Canvas deployments were falling back to the cloud host for automation API calls.
The three-tier host resolution (explicit host → local detection → cloud default) is sound, and the new local session-key authentication guidance is accurate for the local agent-server API. The generated skills/index.js is updated alongside the source skill, which is the correct workflow.
[IMPROVEMENT OPPORTUNITIES]
-
The Authentication section now describes two auth mechanisms (Bearer for cloud,
X-Session-API-Keyfor local), but every curl example in the rest of the skill still uses onlyAuthorization: Bearer ${OPENHANDS_API_KEY}. An agent following this skill in a local Agent Canvas context would see the instruction to useX-Session-API-Keybut then find all ~30 examples using Bearer auth with no guidance on when to switch. Consider adding a brief note near the first curl example (or in the Determining the API Host section) reminding the agent to substitute the appropriate auth header based on the selected host. -
The example
OPENHANDS_HOST="http://localhost:8001"on line 139 replaced the previous cloud-default example. An agent in a cloud context who copies this example verbatim would target localhost instead of the cloud API. The preceding text explains the logic, but the example itself no longer shows the most common (cloud) case. Consider showing both cases, e.g.OPENHANDS_HOST="https://app.all-hands.dev" # or http://localhost:8001 for local Agent Canvas.
[RISK ASSESSMENT]
- [Overall PR]
⚠️ Risk Assessment: 🟢 LOW
Documentation-only changes to a skill definition. No code, no API behavior change, no security surface. The inconsistencies noted above are usability issues for agents consuming the skill, not correctness bugs.
VERDICT:
✅ Worth merging: Core changes are correct and address a real local-deployment problem. The auth/example inconsistencies are minor and can be addressed in a follow-up.
KEY INSIGHT:
The host-resolution logic is right, but the skill's curl examples were not updated to match the new dual-auth guidance, leaving a gap between the documented auth model and the copy-paste examples.
Improve this review? If any feedback above seems incorrect or irrelevant to this repository, you can teach the reviewer to do better:
- Add a
.agents/skills/custom-codereview-guide.mdfile to your branch (or edit it if one already exists) with the/codereviewtrigger and the context the reviewer is missing (e.g., "Security concerns about X do not apply here because Y"). See the customization docs for the required frontmatter format.- Re-request a review - the reviewer reads guidelines from the PR branch, so your changes take effect immediately.
- When your PR is merged, the guideline file goes through normal code review by repository maintainers.
Resolve with AI? Install the iterate skill in your agent and run
/iterateto automatically drive this PR through CI, review, and QA until it's merge-ready.Was this review helpful? React with 👍 or 👎 to give feedback.
Co-authored-by: openhands <openhands@all-hands.dev>
|
👋 This PR needs a couple of things fixed before OpenHands can review it:
Push an update once this is addressed and this check re-runs automatically. This is an automated check - no AI was used to generate this comment. |
|
@all-hands-bot the two findings are addressed in This review request was posted by an AI agent (OpenHands) on behalf of the user. |
|
🤖 OpenHands is reviewing this PR. Head commit: This comment was posted by an AI agent (OpenHands). |
all-hands-bot
left a comment
There was a problem hiding this comment.
This review was created by an AI agent (OpenHands) on behalf of the repository maintainers.
Taste Rating: 🟢 Good taste
This is a well-scoped documentation-only change to the openhands-automation skill that clarifies host selection and authentication for local Agent Canvas deployments. The change correctly belongs in this extensions registry (skills live here).
Verification performed:
- Confirmed the generated
skills/index.jscontent matchesSKILL.md(after frontmatter stripping) - the generated artifact is in sync with the source. - Confirmed
OPENHANDS_AUTOMATION_API_KEYis already used by other skills in the repo (slack-standup-digest, github-issue-to-pr, slack-channel-monitor), so the new auth example is consistent with established patterns. - The
SESSION_API_KEYfallback in theX-Session-API-Keyheader matches the existing No-LLM script helpers section (line 88). - The curl examples throughout the rest of the skill still use cloud Bearer auth, and the text explicitly tells the reader to swap the header for local deployments - no ambiguity.
No material issues found.
[RISK ASSESSMENT]
- [Overall PR] Risk Assessment: 🟢 LOW
Documentation-only change to skill Markdown and its generated catalog mirror. No executable code, no API behavior changes, no dependency changes. The generatedskills/index.jsis verified in sync with the sourceSKILL.md.
VERDICT:
✅ Worth merging: Clean, consistent documentation improvement with no material findings.
KEY INSIGHT:
The PR correctly makes local host detection explicit in the automation skill while keeping the generated catalog artifact in sync with the source.
Improve this review? If any feedback above seems incorrect or irrelevant to this repository, you can teach the reviewer to do better:
- Add a
.agents/skills/custom-codereview-guide.mdfile to your branch (or edit it if one already exists) with the/codereviewtrigger and the context the reviewer is missing (e.g. "Security concerns about X do not apply here because Y"). See the customization docs for the required frontmatter format.- Re-request a review - the reviewer reads guidelines from the PR branch, so your changes take effect immediately.
- When your PR is merged, the guideline file goes through normal code review by repository maintainers.
Resolve with AI? Install the iterate skill in your agent and run
/iterateto automatically drive this PR through CI, review, and QA until it is merge-ready.Was this review helpful? React with 👍 or 👎 to give feedback.
|
@all-hands-bot your current-head review found no material issues and marked this worth merging, but GitHub recorded it as This review request was posted by an AI agent (OpenHands) on behalf of the user. |
|
@openhands-agent please review head This review request was posted by an AI agent (OpenHands) on behalf of the user. |
|
CI is fully green on needs human approval A repository reviewer must submit the one approval required by the This blocker note was posted by an AI agent (OpenHands) on behalf of the user. |
Why
Local Agent Canvas deployments expose the automation API on the local agent server. Falling back immediately to the cloud host can send local automation requests to the wrong deployment.
Summary
http://localhost:8001by default inside a detected local Agent Canvas stack.https://app.all-hands.devas the fallback outside local deployments.Issue Number
Related to #299.
How to Test
node scripts/build-skills-catalog.mjsand confirm it produces no subsequent diff.uv run --group test pytest tests/.python scripts/sync_extensions.py --check.git diff --check.Video/Screenshots
Not applicable - documentation-only changes.
Notes
The generated
skills/index.jsis updated alongside the source skill.This pull request description was updated by an AI agent (OpenHands) on behalf of the user.