-
Notifications
You must be signed in to change notification settings - Fork 86
fix: materialize linked resources before npm publishing #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
neubig
wants to merge
3
commits into
main
Choose a base branch
from
fix/npm-linked-resources
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−3
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| [ | ||
| { | ||
| "source": "factory-extension-npm-resources", | ||
| "source_head": "1bad294d4b9648b14ad335f516edf6f0a6622305", | ||
| "verified": [ | ||
| { | ||
| "file": "skills/github/.claude-plugin/plugin.json", | ||
| "before_present": false, | ||
| "after_regular_file": true, | ||
| "canonical_bytes_match": true | ||
| } | ||
| ], | ||
| "worker_imports_passed": [], | ||
| "archive_size_bytes": 1124055 | ||
| }, | ||
| { | ||
| "source": "factory-extension-watchdog", | ||
| "source_head": "e8a4508296a7f3ec118b7e69ee681ab73bdcd800", | ||
| "verified": [ | ||
| { | ||
| "file": "skills/github/.claude-plugin/plugin.json", | ||
| "before_present": false, | ||
| "after_regular_file": true, | ||
| "canonical_bytes_match": true | ||
| }, | ||
| { | ||
| "file": "skills/github-issue-triage/scripts/github_client.py", | ||
| "before_present": false, | ||
| "after_regular_file": true, | ||
| "canonical_bytes_match": true | ||
| }, | ||
| { | ||
| "file": "skills/github-issue-to-pr/scripts/github_client.py", | ||
| "before_present": false, | ||
| "after_regular_file": true, | ||
| "canonical_bytes_match": true | ||
| }, | ||
| { | ||
| "file": "skills/github-pr-reviewer/scripts/github_client.py", | ||
| "before_present": false, | ||
| "after_regular_file": true, | ||
| "canonical_bytes_match": true | ||
| }, | ||
| { | ||
| "file": "skills/github-delivery-watchdog/scripts/github_client.py", | ||
| "before_present": false, | ||
| "after_regular_file": true, | ||
| "canonical_bytes_match": true | ||
| } | ||
| ], | ||
| "worker_imports_passed": [ | ||
| "github-issue-triage", | ||
| "github-issue-to-pr", | ||
| "github-pr-reviewer", | ||
| "github-delivery-watchdog" | ||
| ], | ||
| "archive_size_bytes": 1185905 | ||
| } | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Actual npm archive verification | ||
|
|
||
| September 13, 2026. [Recorded results](npm-archives.json) identify the exact main and composed factory source commits. | ||
|
|
||
| From clean source checkouts, ran `npm pack --ignore-scripts --json` before and after the workflow's release staging operation: | ||
|
|
||
| ```bash | ||
| mkdir -p "$RUNNER_TEMP/extensions-package" | ||
| cp -RL . "$RUNNER_TEMP/extensions-package/" | ||
| ``` | ||
|
|
||
| Packed the staged directory, extracted its real tarball, and compared resource bytes with the canonical source. Main's `skills/github/.claude-plugin/plugin.json` and the four composed factory `scripts/github_client.py` resources were absent before staging. After staging, each was an ordinary file with identical contents. All four standalone workers imported successfully from the extracted npm package in an environment with their SDK dependencies installed. Package sizes were approximately 1.1–1.2 MB. | ||
|
|
||
| `cp -aL` was also tried and rejected: preserving hard-link identity led to malformed hard links with npm 11.6.2 and an internal packaging failure with npm 11.18.0. `cp -RL` creates independent regular files and passed actual archive extraction/imports. | ||
|
|
||
| This verifies release artifacts, not a changed Canvas interface. Raw `npm pack` from the linked source checkout still omits links; the production release workflow packs and publishes its materialized copy consistently. No npm release was published during validation. The functional change is confined to release staging; no loader, runtime, or fallback import code was introduced. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.