Conversation
Closes #5035 Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
|
📁 PR Artifacts Notice This PR contains a |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HUMAN:
AGENT:
Why
A conversation can be created and its initial message started even if its POST response is lost. The TypeScript client currently reports failure, leaving Canvas unable to open that conversation.
Summary
Reconcile a transport failure with bounded GET requests using the caller's stable conversation ID. Never replay the create POST. Preserve ordinary HTTP errors and the original transport error if reconciliation fails. This is independent of runtime routing and Docker provisioning.
Issue Number
Closes #5035. Extracted from #4966 to keep the runtime API foundation focused.
How to Test
cd clients/typescript && npm run test:coverage && npm run lint && npm run build && npm run format:check324 tests passed across 20 suites. Six targeted tests use a real HTTP server to drop a successful POST response, delay visibility, and check rejection handling. Against main, four recovery scenarios fail; all six pass with this fix. Live before/after Canvas recordings inject the same lost successful response. Before the fix, Canvas shows disconnected errors; after it, the real agent completes without an error. Both cases send exactly one create POST.
Type
Notes
Targets main and is not a prerequisite for the runtime PR stack. The default additional recovery window is 120 seconds; callers can set
creationRecoveryTimeout.🐳 Agent Server images for this PR — GHCR package, pull/run commands, and all pushed tags (click to expand)
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22-slimnikolaik/python-nodejs:python3.13-nodejs22-slimgolang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:7b69c3a-pythonRun
All tags pushed for this build
About Multi-Architecture Support
7b69c3a-python) is a multi-arch manifest supporting both amd64 and arm647b69c3a-python-amd64) are also available if needed