fix modern XKore2 login and map snapshots - #4221
Draft
rmarquesbarcelona wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0ACFand pin the modern packet mappings needed by a 2020 clientWhy
XKore2 still reconstructed several client snapshots with legacy packet layouts. A modern client could reach the proxy, but authentication or map initialization would fail, and successful attachments could show incomplete inventory/equipment or omit actors that existed before the client attached.
This refreshes the useful parts of #3781 and adds the missing packet capture/replay and parser corrections found during an end-to-end investigation.
Validation
0436map login /007Dload flow and09FFactor snapshots0ACFRijndael password parserstart.exe --helploaded the modified source tree and exited with code 0; only the existing Win32 console-size warnings were emittedThe PR remains a draft for maintainer review of the protocol compatibility scope.
Privacy
No private-server configuration, account credentials, character names, or captured user data are included.
Related: #3781