Skip to content

fix modern XKore2 login and map snapshots - #4221

Draft
rmarquesbarcelona wants to merge 3 commits into
OpenKore:masterfrom
rmarquesbarcelona:agent/xkore2-modern-snapshot
Draft

fix modern XKore2 login and map snapshots#4221
rmarquesbarcelona wants to merge 3 commits into
OpenKore:masterfrom
rmarquesbarcelona:agent/xkore2-modern-snapshot

Conversation

@rmarquesbarcelona

@rmarquesbarcelona rmarquesbarcelona commented Aug 1, 2026

Copy link
Copy Markdown

Summary

  • carry forward the modern-client XKore2 work from fix: update xkore 2 to support new clients #3781 while preserving its original commit authorship
  • decode the 32-byte Rijndael password used by 0ACF and pin the modern packet mappings needed by a 2020 client
  • replay captured character-selection and inventory snapshots so the attached client receives complete modern records
  • fix XKore2 map bootstrap and snapshot assembly issues that dropped equipment, skills, appearance data, and actors already on screen

Why

XKore2 still reconstructed several client snapshots with legacy packet layouts. A modern client could reach the proxy, but authentication or map initialization would fail, and successful attachments could show incomplete inventory/equipment or omit actors that existed before the client attached.

This refreshes the useful parts of #3781 and adds the missing packet capture/replay and parser corrections found during an end-to-end investigation.

Validation

  • verified an end-to-end XKore2 attach against a rAthena server using a 2020 client: account, character, and map login completed
  • confirmed the attached client received the complete 18-item inventory, equipped Knife and Cotton Shirt, and a Poring that was already on screen
  • confirmed the modern 0436 map login / 007D load flow and 09FF actor snapshots
  • added and passed a regression test for the 32-byte 0ACF Rijndael password parser
  • passed the complete Windows unit suite: 1,185 tests with zero failures, using Perl 5.12.3 x86 matching the bundled XSTools DLL
  • start.exe --help loaded the modified source tree and exited with code 0; only the existing Win32 console-size warnings were emitted

The PR remains a draft for maintainer review of the protocol compatibility scope.

Privacy

No private-server configuration, account credentials, character names, or captured user data are included.

Related: #3781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants