created docker_containers collector based on docker/docker-py#355
Open
ChristianKniep wants to merge 4 commits intoOpenTSDB:masterfrom
Open
created docker_containers collector based on docker/docker-py#355ChristianKniep wants to merge 4 commits intoOpenTSDB:masterfrom
ChristianKniep wants to merge 4 commits intoOpenTSDB:masterfrom
Conversation
Member
|
Is the namespace for these metrics the same as the current docker collector? |
Author
|
@johann8384 Ehm, dunno... have to check for this |
e495ac3 to
c5b5764
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
docker.pycollector is not usingdocker/docker-py, so I created a collector that uses that library.I renamed it to
docker_containersbecause a)dockerconflicts with the library used and b) I reckon there whould be adocker_enginecollector as well.Test coverage is 77%...