Add deprecate and resolve workflow run policy - #26
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Verified Permissions definitions for workflow-run deprecation and resolution.
Changes:
- Adds Cedar actions and curator deprecation policy.
- Adds authorization tests and documentation.
- Broadly upgrades project dependencies.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
infrastructure/authorization-manager/stage/stack.ts |
Adds curator deprecation policy. |
infrastructure/authorization-manager/stage/cedarSchema.json |
Registers protected transition actions. |
infrastructure/authorization-manager/stage/README.md |
Documents permissions. |
test/authorization-manager.test.ts |
Tests schema and policies. |
package.json |
Upgrades dependencies. |
pnpm-lock.yaml |
Regenerates dependency lock data. |
pnpm-workspace.yaml |
Removes resolution overrides. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| id: 'CognitoWorkflowDeprecatePolicy', | ||
| groups: ['curators'], | ||
| description: 'Permissions to mark a workflowrun as deprecated in WORKFLOW microservice', | ||
| actions: ['POST /api/v1/workflowrun/state/deprecate'], |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
package.json:48
- The PR description scopes this change to workflow-run authorization, but these production CDK/construct upgrades (along with the toolchain and lockfile churn) add a separate dependency-audit change that can affect synthesized infrastructure. Please either split the dependency remediation into its own PR or document its rationale and validation in this PR so the deployment impact can be reviewed against the stated scope.
"@aws-cdk/aws-lambda-python-alpha": "2.263.0-alpha.0",
"@orcabus/platform-cdk-constructs": "1.8.0",
"aws-cdk-lib": "^2.263.0",
"constructs": "^10.8.1"
reisingerf
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve: OrcaBus/service-workflow-manager#175.
Couple with PR: OrcaBus/service-workflow-manager#176
Add AWS Verified Permissions support for the new workflow-run state transition endpoints.
Changes
deprecatedworkflow-run action toGROUP_POLICIES.deprecatedandresolvedactions to the strict Cedar schema.resolvedadmin-only through the existing admin wildcard policy.cancelfrom Verified Permissions because the endpoint is available to all authenticated users and does not use the AVP authorizer.deprecated.resolved.cancelfrom the Cedar schema.Permission Matrix