feat: Icon picker#186
Draft
alex289 wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a reusable Lucide icon picker component to the frontend and introduces an “Icon” field in the agent upsert dialog to support selecting an icon for agents (per issue #185).
Changes:
- Added
LucideIconPickercomponent backed by the existingComboboxUI primitives. - Extended the agent upsert form to include an
iconfield and UI for selecting it. - Added new i18n strings for the icon field (EN/DE).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| frontend/src/components/lucide-icon-picker.tsx | New Lucide icon picker component using lucide-react/dynamic + combobox UI. |
| frontend/src/components/dialogs/upsert-agent.tsx | Adds icon form field and renders the icon picker in the agent create/edit dialog. |
| frontend/messages/en.json | Adds EN strings for icon picker UI. |
| frontend/messages/de.json | Adds DE strings for icon picker UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
49
to
53
| const form = useForm({ | ||
| defaultValues: { | ||
| name: agent?.name ?? "", | ||
| icon: defaultAgentIcon as string, | ||
| }, |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Adds an lucide icon picker for the agent and applications
Fixeds #185