Skip to content

chore: update rollup config, commit lockfiles - #173

Merged
naddison36 merged 2 commits into
mainfrom
feat/rollup_config
Dec 3, 2025
Merged

naddison36 merged 2 commits into
mainfrom
feat/rollup_config

Conversation

@toniocodo

Copy link
Copy Markdown
Contributor

This is an attempt to fix rollup compilation and config:

  • update paths in rollup to make the job executable anywhere
  • add nomicfoundation to external deps to avoid bundling native code
  • commit yarn lockfile to have deterministic builds

The rollup task can now be launched from repo root with "yarn rollup -c src/js/actions/rollup.config.cjs"

@toniocodo
toniocodo requested a review from clement-ux December 3, 2025 10:11
Comment on lines +60 to +68

module.exports = actions.map((action) => ({
input: path.resolve(__dirname, `${action}.js`),
output: {
file: path.resolve(__dirname, `dist/${action}/index.js`),
format: "cjs",
},
...commonConfig,
}));

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is 100x better like this thanks!!

naddison36
naddison36 previously approved these changes Dec 3, 2025

@naddison36 naddison36 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an awesome improvement. thanks

@naddison36
naddison36 merged commit cf287cc into main Dec 3, 2025
8 checks passed
@naddison36
naddison36 deleted the feat/rollup_config branch December 3, 2025 10:26
@clement-ux clement-ux added the Tooling Scripts, automation, and utilities. label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tooling Scripts, automation, and utilities.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants