Skip to content

Document new filters, slot values, and cleanup#294

Open
TheRealPear wants to merge 2 commits intoPGMDev:masterfrom
TheRealPear:20251219-update
Open

Document new filters, slot values, and cleanup#294
TheRealPear wants to merge 2 commits intoPGMDev:masterfrom
TheRealPear:20251219-update

Conversation

@TheRealPear
Copy link
Copy Markdown
Contributor

Comment on lines +21 to +30
| `any` | Any equipment slot, the default if not set. |
| `mainhand` ||
| `offhand` ||
| `hand` | Either main or off-hand. |
| `feet` ||
| `legs` ||
| `chest` ||
| `head` ||
| `armor` | Any armor piece. |
| `body` | Used for entities with no feet/legs/chest/head distinction, e.g. horses with armor. |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These need to be prefixed with either

slot.armor.[head/chest/legs/feet]
slot.weapon.[mainhand/offhand]
slot.hotbar.[0-8]
slot.inventory.[0-26]

Don't think any and body are used by PGM?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was my understanding that prefixes are optional now. As for any and body, the pull request recommended that they were documented.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure if modern is different, but 1.8 still needs the prefixes and any and body throw errors

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any and body make sense for attributes, so you can say armor gives defense when on body, or you can say a star gives speed if on any slot (ie: mainhand, offhand, or even equipped would work)

@TheRealPear TheRealPear marked this pull request as draft January 25, 2026 18:19
@TheRealPear TheRealPear force-pushed the 20251219-update branch 2 times, most recently from 9c586b9 to d582c2b Compare February 5, 2026 22:35
@TheRealPear TheRealPear marked this pull request as ready for review February 15, 2026 05:16
Comment thread docs/reference/misc/banners.mdx
Comment thread docs/modules/mechanics/filters.mdx Outdated
TheRealPear and others added 2 commits April 23, 2026 23:24
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
Co-authored-by: Patrick <CoWinkKeyDinkInc@users.noreply.github.com>
Signed-off-by: Pear <20259871+TheRealPear@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Document new-old filters Update slot attributes documentation

4 participants